net/sysfs: Fix the bitrot in network device kobject namespace support
in [Kernel]
|
Prev: linux-next -> 2.6.34: Tree for April 28 (logfs)
Next: [PATCH 7/6] net/sysfs: Fix the bitrot in network device kobject namespace support
From: David Miller on 17 May 2010 01:10 From: ebiederm(a)xmission.com (Eric W. Biederman) Date: Sun, 16 May 2010 21:59:45 -0700 > > I had a couple of stupid bugs in: > netns: Teach network device kobjects which namespace they are in. > > - I duplicated the Kconfig for the NET_NS > - The build was broken when sysfs was not compiled in > > The sysfs breakage is because after I moved the operations > for the sysfs to the kobject layer, to make things cleaner > I forgot to move the ifdefs. Opps. > > I'm not quite certain how I got introduced a second NET_NS Kconfig, > but it was probably a 3 way merge somewhere along the way that > did not notice that the NET_NS Kconfig option had mvoed and thout > that was a bug. It probably slipped in because it used to be the > sysfs patches were the first patches in my network namespace patches. > Some things just don't go like you would expect. > > Neither of these bugs actually affect anything in the common case > but they should be fixed. > > Thanks to Serge for noticing they were present. > > Reported-by: Serge E. Hallyn <serue(a)us.ibm.com> > Signed-off-by: Eric W. Biederman <ebiederm(a)aristanetworks.com> Acked-by: David S. Miller <davem(a)davemloft.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |