From: David Miller on

A couple problems remaining in this patch set:

1) Too many bug fixes for this late in the -rc series of 2.6.35
Pick a smaller number of fixes, the most critical ones, perhaps
2 or 3, and re-submit those for net-2.6

Pick the ones that produce easily triggers crashes or documented
regressions present on the official lkml regression list.

Send the rest in for net-next-2.6

2) Bumping the driver version every patch in a patch series is pointless.
Do the bump once, at the end of the series.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Shreyas Bhatewara on


> -----Original Message-----
> From: David Miller [mailto:davem(a)davemloft.net]
> Sent: Wednesday, July 07, 2010 2:41 PM
> To: Shreyas Bhatewara
> Cc: netdev-devel(a)vger.kernel.org; linux-kernel(a)vger.kernel.org; pv-
> drivers(a)vmware.com; Michael Stolarchuk
> Subject: Re: [PATCH 2.6.35-rc1] net: vmxnet3 fixes [0/5] Spare skb to
> avoid starvation
>
>
> A couple problems remaining in this patch set:
>
> 1) Too many bug fixes for this late in the -rc series of 2.6.35
> Pick a smaller number of fixes, the most critical ones, perhaps
> 2 or 3, and re-submit those for net-2.6
>
> Pick the ones that produce easily triggers crashes or documented
> regressions present on the official lkml regression list.
>
> Send the rest in for net-next-2.6

Could you please apply all the patches in the series to net-next-2.6, the patches will apply cleanly. Or would you rather have them reposted them with proper subject line ?

>
> 2) Bumping the driver version every patch in a patch series is
> pointless.
> Do the bump once, at the end of the series.


The version numbers bumps although seemingly pointless (and harmless), make my life easy to track and maintain the bug#-to-fix mapping.


Thanks.
->Shreyas


>
> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on
From: Shreyas Bhatewara <sbhatewara(a)vmware.com>
Date: Wed, 7 Jul 2010 15:19:08 -0700

> The version numbers bumps although seemingly pointless (and
> harmless), make my life easy to track and maintain the bug#-to-fix
> mapping.

But in an upstream context, they make no sense at all.

Anyone running upstream, is going to run at the last version bump you
make in the driver, so what users report to you as the driver version
will be correct.

Please fix this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/