only drop root anon_vma if not self
in [Kernel]
|
Prev: [PATCH 4/4] staging: rtl8192u: fix checkpatch.pl issues to line 3500 Fix most problems pointed out by checkpatch.pl in file r8192U_core.c up to line 3500
Next: MAINTAINERS: Update ARM/NUVOTON W90X900 ARM ARCHITECTURE file patterns
From: Dave Young on 11 Jun 2010 05:50 On Fri, Jun 11, 2010 at 5:30 PM, Dave Young <hidave.darkstar(a)gmail.com> wrote: > On Fri, Jun 11, 2010 at 5:17 PM, Catalin Marinas > <catalin.marinas(a)arm.com> wrote: >> Dave Young <hidave.darkstar(a)gmail.com> wrote: >>> On Thu, Jun 10, 2010 at 7:21 PM, Catalin Marinas >>> <catalin.marinas(a)arm.com> wrote: >>>> On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote: >>>>> On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel <riel(a)redhat.com> wrote: >>>>> > On Wed, 9 Jun 2010 17:19:02 +0800 >>>>> > Dave Young <hidave.darkstar(a)gmail.com> wrote: >>>>> > >>>>> >> > Manually bisected mm patches, the memleak caused by following patch: >>>>> >> > >>>>> >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch >>>>> >> >>>>> >> >>>>> >> So I guess the refcount break, either drop-without-get or over-drop >>>>> > >>>>> > I'm guessing I did not run the kernel with enough debug options enabled >>>>> > when I tested my patches... >>>>> > >>>>> > Dave & Catalin, thank you for tracking this down. >>>>> > >>>>> > Dave, does the below patch fix your issue? >>>>> >>>>> Yes, it fixed the issue. Thanks. >>>> >>>> Thanks for investigating this issue. >>>> >>>> BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled), >>>> do you get other leaks (false positives). >>> >>> I didn't see difference before/after apply your patch, how to test >>> specific to bootmem? >> >> With Rik's patch applied and CONFIG_NOBOOTMEM enabled, do you get any >> false postives if my kmemleak patch isn't applied? > > No more, except a few acpi issue which always there > I got an oops when shutdown kvm guest with rik's patch applied, but without your bootmem patch, is it kmemleak problem? attached the screendump >> >> Thanks. >> >> -- >> Catalin >> > > > > -- > Regards > dave > -- Regards dave
From: Catalin Marinas on 11 Jun 2010 06:10 On Fri, 2010-06-11 at 10:48 +0100, Dave Young wrote: > I got an oops when shutdown kvm guest with rik's patch applied, but > without your bootmem patch, is it kmemleak problem? It could be, though I've never got it before. Can you run this on your vmlinux file? addr2line -i -f -e vmlinux c10c5c88 Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Dave Young on 11 Jun 2010 22:00
On Fri, Jun 11, 2010 at 6:06 PM, Catalin Marinas <catalin.marinas(a)arm.com> wrote: > On Fri, 2010-06-11 at 10:48 +0100, Dave Young wrote: >> I got an oops when shutdown kvm guest with rik's patch applied, but >> without your bootmem patch, is it kmemleak problem? > > It could be, though I've never got it before. > > Can you run this on your vmlinux file? > > addr2line -i -f -e vmlinux c10c5c88 The vmlinux is lost, I rebuid it with same config bash-3.1$ addr2line -i -f -e vmlinux 0xc10c5c88 put_object /home/dave/mm/linux-2.6.35-rc1/mm/kmemleak.c:45 > > Thanks. > > -- > Catalin > > -- Regards dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |