Prev: [PATCH 2/2] let-message-queue-timeout-use-hrtimer.patch
Next: [PATCH] hwmon:applesmc: Add support for iMac 9.
From: Oleg Nesterov on 2 Apr 2010 17:10
On 04/02, David Rientjes wrote:
>
> An oom_badness() score of 0 means "never kill" according to
> Documentation/filesystems/proc.txt, so explicitly exclude it from being
> selected for kill. These tasks have either detached their p->mm or are
> set to OOM_DISABLE.

Agreed, but

> @@ -336,6 +336,8 @@ static struct task_struct *select_bad_process(unsigned int *ppoints,
> continue;
>
> points = oom_badness(p, totalpages);
> + if (!points)
> + continue;
> if (points > *ppoints || !chosen) {

then "|| !chosen" can be killed.

with this patch !chosen <=> !*ppoints, and since points > 0

if (points > *ppoints) {

is enough.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/2] let-message-queue-timeout-use-hrtimer.patch
Next: [PATCH] hwmon:applesmc: Add support for iMac 9.