oom: /proc/<pid>/oom_score treat kernel thread honestly
in [Kernel]
|
Prev: [PATCHv3 7/9] dspbridge: move all iommu related code to a new file
Next: oom: move OOM_DISABLE check from oom_kill_task to out_of_memory()
From: KOSAKI Motohiro on 30 Jun 2010 20:10 > On Wed, Jun 30, 2010 at 06:30:19PM +0900, KOSAKI Motohiro wrote: > > If kernel thread are using use_mm(), badness() return positive value. > > This is not big issue because caller care it correctly. but there is > > one exception, /proc/<pid>/oom_score call badness() directly and > > don't care the task is regular process. > > > > another example, /proc/1/oom_score return !0 value. but it's unkillable. > > This incorrectness makes confusing to admin a bit. > > Hmm. If it is a really problem, Could we solve it in proc_oom_score itself? probably, no good idea. For maintainance view, all oom related code should be gathered in oom_kill.c. If you dislike to add messy into badness(), I hope to make badness_for_oom_score() or something like instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |