p54spi: replace internal "cx3110x" name with "p54spi"
in [Kernel]
|
Prev: Input: ads7846: Fix warning about output format
Next: - race-free suspend. Was: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8)
From: Johannes Berg on 2 Jun 2010 04:00 On Tue, 2010-06-01 at 21:16 -0500, Luke-Jr wrote: > static struct spi_driver p54spi_driver = { > .driver = { > - /* use cx3110x name because board-n800.c uses that for the > - * SPI port */ > - .name = "cx3110x", > + .name = "p54spi", > .bus = &spi_bus_type, maybe that comment wasn't clear enough ... it needs to be that way to be properly linked up against SPI. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Luke-Jr on 2 Jun 2010 15:10 On Wednesday 02 June 2010 02:54:59 am Johannes Berg wrote: > On Tue, 2010-06-01 at 21:16 -0500, Luke-Jr wrote: > > static struct spi_driver p54spi_driver = { > > .driver = { > > - /* use cx3110x name because board-n800.c uses that for the > > - * SPI port */ > > - .name = "cx3110x", > > + .name = "p54spi", > > .bus = &spi_bus_type, > > maybe that comment wasn't clear enough ... it needs to be that way to be > properly linked up against SPI. I don't understand what you mean here. Does the hardware-side of SPI use string identifiers? These are the only two instances of "cx3110x" in the kernel source; N8x0 board files expect "p54spi" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Johannes Berg on 4 Jun 2010 04:40
On Wed, 2010-06-02 at 14:06 -0500, Luke-Jr wrote: > > > .driver = { > > > - /* use cx3110x name because board-n800.c uses that for the > > > - * SPI port */ > > > - .name = "cx3110x", > > > + .name = "p54spi", > > > .bus = &spi_bus_type, > > > > maybe that comment wasn't clear enough ... it needs to be that way to be > > properly linked up against SPI. > > I don't understand what you mean here. Does the hardware-side of SPI use > string identifiers? These are the only two instances of "cx3110x" in the > kernel source; N8x0 board files expect "p54spi" Hm, ok, I thought that the board stuff needed cx3110x. Hopefully it doesn't differ in n810s? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |