Prev: [PATCH v2] block: avoid unconditionally freeing previously allocated request_queue
Next: [PATCH 0/2] Enlarge the storage of chars in virtual terminal
From: Steffen Klassert on 26 May 2010 02:40
On Tue, May 25, 2010 at 11:29:13PM +0200, Dan Carpenter wrote:
> MAX_SEQ_NR is used in padata_alloc_pd() like this:
>
> pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;
>
> It needs parenthesis or the divide by num_cpus takes precedence over the
> subtraction.
>
> Signed-off-by: Dan Carpenter <error27(a)gmail.com>

Acked-by: Steffen Klassert <steffen.klassert(a)secunet.com>

Thanks,

Steffen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 3 Jun 2010 06:30
On Wed, May 26, 2010 at 08:32:27AM +0200, Steffen Klassert wrote:
> On Tue, May 25, 2010 at 11:29:13PM +0200, Dan Carpenter wrote:
> > MAX_SEQ_NR is used in padata_alloc_pd() like this:
> >
> > pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;
> >
> > It needs parenthesis or the divide by num_cpus takes precedence over the
> > subtraction.
> >
> > Signed-off-by: Dan Carpenter <error27(a)gmail.com>
>
> Acked-by: Steffen Klassert <steffen.klassert(a)secunet.com>

Applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert(a)gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v2] block: avoid unconditionally freeing previously allocated request_queue
Next: [PATCH 0/2] Enlarge the storage of chars in virtual terminal