padata: cpumasks
in [Kernel]
|
Prev: [PATCH] drbd: Remove __packed define
Next: crypto: Convert pci_table entries to PCI_VDEVICE (if PCI_ANY_ID is used)
From: Herbert Xu on 19 Jul 2010 02:10 On Wed, Jul 14, 2010 at 02:29:51PM +0400, Dan Kruchinin wrote: > This is my third attempt to send padata cpumasks patchset. > The patchset includes fixes of all unclear things Steffen noted in previous two patchsets. > Changes: > > 1) Make two cpumasks in padata instead of one. The first cpumask is used by parallel workers and > another is used by the workers doing serialization. Two distinguish cpumasks perform to build > configuration where CPUs used by parallel and serial workers aren't intersect. It significantly > improves performance. > Each padata instance now includes notifier chain which can be used by users interested in instance's > cpumask(serial or parallel) change. If one of cpumask is changed an event is generated. > > 2) Add sysfs primitives to padata. Each padata instance contains kobject which can be embedded to any > proper sysfs hierarchy. Padata kobject can be used to change or show serial or parallel cpumask. > > 3) Add sysfs representation to pcrypt. Pcrypt now creates /sys/kernel/pcrypt/[pencrypt|pdecrypt] during > module loading phase. pencrypt and pdecrypt directories are represented by kobjects of padata instances > that belongs to pencrypt and pdecrypt respectively. Using this sysfs interface user can change and read > serial and parallel cpumasks of both instances. All applied. Thanks! -- Email: Herbert Xu <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Steffen Klassert on 19 Jul 2010 02:40 On Mon, Jul 19, 2010 at 02:04:26PM +0800, Herbert Xu wrote: > > All applied. Thanks! Hm, I was just about to write some comments on these patches, they still have some issues. For example, handling empty cpumasks is broken again (NULL pointer dereference in padata_replace). The cpu_index is zero for all cpus now, so can we leak objects on cpu hotplug etc. Also I'm not that happy with some of the API changes. I'll try to fix this up with some patches. Steffen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Herbert Xu on 19 Jul 2010 03:40
On Mon, Jul 19, 2010 at 08:40:50AM +0200, Steffen Klassert wrote: > On Mon, Jul 19, 2010 at 02:04:26PM +0800, Herbert Xu wrote: > > > > All applied. Thanks! > > Hm, I was just about to write some comments on these patches, > they still have some issues. For example, handling empty cpumasks > is broken again (NULL pointer dereference in padata_replace). > The cpu_index is zero for all cpus now, so can we leak objects > on cpu hotplug etc. Also I'm not that happy with some of the > API changes. I'll try to fix this up with some patches. OK I'll take your fixes on top when you're ready. Thanks! -- Email: Herbert Xu <herbert(a)gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |