Prev: [PATCH] partitions: fix build error in ibm partition detection code
Next: [PATCH] uml: fix compile error in dma_get_cache_alignment()
From: Andreas Schwab on 12 Aug 2010 05:00
Heiko Carstens <heiko.carstens(a)de.ibm.com> writes:

> - strlcat(tmp, sizeof(tmp), "(nonl)", PAGE_SIZE);
> + snprintf(tmp, sizeof(tmp), "(nonl)");
> + strlcat(state->pp_buf, tmp, PAGE_SIZE);

What's the point of tmp and snprintf if it just creates a copy of a
constant string?

strlcat(state->pp_buf, "(nonl)", PAGE_SIZE);

Andreas.

--
Andreas Schwab, schwab(a)redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] partitions: fix build error in ibm partition detection code
Next: [PATCH] uml: fix compile error in dma_get_cache_alignment()