[patch 2/3] btrfs cleanup: remove more dead code
in [Kernel]
|
Prev: [patch 1/3] btrfs: checking for NULL instead of IS_ERR()
Next: [patch 3/3] btrfs cleanup: unneeded null check
From: Dan Carpenter on 20 Mar 2010 07:40 rb_node cannot be an ERR_PTR() here so I removed the misleading check. Also I removed some more dead code at the bottom. It looks like the code from lookup_extent_mapping() may have been copy and pasted into search_extent_mapping()? Signed-off-by: Dan Carpenter <error27(a)gmail.com> --- This doesn't change anything. Could you put it into linux-next? diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index 94668b1..010f299 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c @@ -380,16 +380,7 @@ struct extent_map *search_extent_mapping(struct extent_map_tree *tree, em = NULL; goto out; } - if (IS_ERR(rb_node)) { - em = ERR_PTR(PTR_ERR(rb_node)); - goto out; - } em = rb_entry(rb_node, struct extent_map, rb_node); - goto found; - - em = NULL; - goto out; - found: atomic_inc(&em->refs); out: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |