[patch 3/4] x86,perf: P4 PMU -- Get rid of redundant check for array index
in [Kernel]
|
Prev: [patch 4/4] x86,perf: P4 PMU -- check for proper event index in RAW events
Next: Partial Array Self-Refresh on linux embedded systems
From: Cyrill Gorcunov on 8 May 2010 07:30 The caller already has done such a check. And it was wrong anyway, it had to be '>=' rather then '>' CC: Peter Zijlstra <peterz(a)infradead.org> CC: Ingo Molnar <mingo(a)elte.hu> CC: Frederic Weisbecker <fweisbec(a)gmail.com> CC: Lin Ming <ming.m.lin(a)intel.com> Signed-off-by: Cyrill Gorcunov <gorcunov(a)openvz.org> --- arch/x86/kernel/cpu/perf_event_p4.c | 5 ----- 1 file changed, 5 deletions(-) Index: linux-2.6.git/arch/x86/kernel/cpu/perf_event_p4.c ===================================================================== --- linux-2.6.git.orig/arch/x86/kernel/cpu/perf_event_p4.c +++ linux-2.6.git/arch/x86/kernel/cpu/perf_event_p4.c @@ -406,11 +406,6 @@ static u64 p4_pmu_event_map(int hw_event unsigned int esel; u64 config; - if (hw_event > ARRAY_SIZE(p4_general_events)) { - printk_once(KERN_ERR "P4 PMU: Bad index: %i\n", hw_event); - return 0; - } - config = p4_general_events[hw_event]; bind = p4_config_get_bind(config); esel = P4_OPCODE_ESEL(bind->opcode); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |