From: Greg KH on
On Thu, Jul 29, 2010 at 12:49:59PM +0530, Savoy, Pavan wrote:
> Greg,
>
>
> > -----Original Message-----
> > From: gregkh(a)suse.de [mailto:gregkh(a)suse.de]
> > Sent: Wednesday, July 28, 2010 10:24 AM
> > To: Savoy, Pavan; gregkh(a)suse.de
> > Subject: patch "Staging: ti-st: update ABI and TODO" added to staging-next tree
>
> Is it good enough to be moved out of staging?

I don't know, I haven't reviewed it. Do you want me to do so? It looks
like you still have a number of things on your TODO list, why not
resolve those first?

> I mean the multi-device thingy would be more or less a nice to have
> feature than being a bug, isn't it?

I don't think Alan thinks so.

> The ease for me would be once out of staging, I can cleanup the
> platform device mess too, since our L-O tree needs to be have some
> patches in the arch/arm/board-XX.c sort of files...

Promises to clean up code after it leaves staging is generally not a
good idea :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Savoy, Pavan on

> -----Original Message-----
> From: Greg KH [mailto:gregkh(a)suse.de]
> Sent: Thursday, July 29, 2010 9:53 AM
> To: Savoy, Pavan
> Cc: linux-kernel(a)vger.kernel.org
> Subject: Re: patch "Staging: ti-st: update ABI and TODO" added to staging-next tree
>
> On Thu, Jul 29, 2010 at 12:49:59PM +0530, Savoy, Pavan wrote:
> > Greg,
> >
> >
> > > -----Original Message-----
> > > From: gregkh(a)suse.de [mailto:gregkh(a)suse.de]
> > > Sent: Wednesday, July 28, 2010 10:24 AM
> > > To: Savoy, Pavan; gregkh(a)suse.de
> > > Subject: patch "Staging: ti-st: update ABI and TODO" added to staging-next tree
> >
> > Is it good enough to be moved out of staging?
>
> I don't know, I haven't reviewed it. Do you want me to do so? It looks
> like you still have a number of things on your TODO list, why not
> resolve those first?

The major thing on the TODO list was this multiple device support.
The rest is taken care, I will send out a patch to update the TODO itself!!
So, Please review and provide comment as to what should be done to move it out of staging into may be drivers/misc? or mfd/ suggest a suitable place holder too.

> > I mean the multi-device thingy would be more or less a nice to have
> > feature than being a bug, isn't it?
>
> I don't think Alan thinks so.

As Alan mentioned this is currently un-testable since we don't have such platforms with multiple of these connectivity chipsets.

> > The ease for me would be once out of staging, I can cleanup the
> > platform device mess too, since our L-O tree needs to be have some
> > patches in the arch/arm/board-XX.c sort of files...
>
> Promises to clean up code after it leaves staging is generally not a
> good idea :)

Not a clean up as such but pending patches such as addition of the platform device into the arch/arm/mach-omap2/board-4430sdp.c file or board-zoom2.c file.
Or the V4L2 FM drivers for the FM core on chip, which makes use of this ldisc..
This is to make sure that any Linux release built for such boards have this driver up and running for the device.

I have cleaned-up all I can, I suppose :)

> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/