[patch]hp_accel: Fix race in device removal
in [Kernel]
|
Prev: [PATCH] uml: Convert to unlocked_ioctls to remove implicit BKL
Next: Deadlock in NFSv4 in all kernels
From: Oliver Neukum on 7 May 2010 11:50 From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001 From: Oliver Neukum <oliver(a)neukum.org> Date: Fri, 7 May 2010 17:41:59 +0200 Subject: [PATCH] hp_accel: Fix race in device removal The work queue has to be flushed after the device has been made inaccessible. Signed-off-by: Oliver Neukum <oneukum(a)suse.de> --- drivers/hwmon/hp_accel.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c index c8ab505..6f6e05d 100644 --- a/drivers/hwmon/hp_accel.c +++ b/drivers/hwmon/hp_accel.c @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) lis3lv02d_joystick_disable(); lis3lv02d_poweroff(&lis3_dev); - flush_work(&hpled_led.work); led_classdev_unregister(&hpled_led.led_classdev); - + flush_work(&hpled_led.work); + return lis3lv02d_remove_fs(&lis3_dev); } -- 1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jean Delvare on 7 May 2010 12:00 Hi Oliver, On Fri, 7 May 2010 17:47:40 +0200, Oliver Neukum wrote: > From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001 > From: Oliver Neukum <oliver(a)neukum.org> > Date: Fri, 7 May 2010 17:41:59 +0200 > Subject: [PATCH] hp_accel: Fix race in device removal > > The work queue has to be flushed after the device has been made > inaccessible. > > Signed-off-by: Oliver Neukum <oneukum(a)suse.de> > --- > drivers/hwmon/hp_accel.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c > index c8ab505..6f6e05d 100644 > --- a/drivers/hwmon/hp_accel.c > +++ b/drivers/hwmon/hp_accel.c > @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) > lis3lv02d_joystick_disable(); > lis3lv02d_poweroff(&lis3_dev); > > - flush_work(&hpled_led.work); > led_classdev_unregister(&hpled_led.led_classdev); > - > + flush_work(&hpled_led.work); > + > return lis3lv02d_remove_fs(&lis3_dev); > } > You are adding trailing white space. Please don't. Use scripts/checkpatch.pl to check your patches before you send them. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Oliver Neukum on 7 May 2010 12:10
Am Freitag, 7. Mai 2010 17:54:01 schrieb Jean Delvare: > Hi Oliver, > > On Fri, 7 May 2010 17:47:40 +0200, Oliver Neukum wrote: > > From 64a9e0d8e585c65526248e6cf1659a13fb01a93a Mon Sep 17 00:00:00 2001 > > From: Oliver Neukum <oliver(a)neukum.org> > > Date: Fri, 7 May 2010 17:41:59 +0200 > > Subject: [PATCH] hp_accel: Fix race in device removal > > > > The work queue has to be flushed after the device has been made > > inaccessible. > > > > Signed-off-by: Oliver Neukum <oneukum(a)suse.de> > > --- > > drivers/hwmon/hp_accel.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwmon/hp_accel.c b/drivers/hwmon/hp_accel.c > > index c8ab505..6f6e05d 100644 > > --- a/drivers/hwmon/hp_accel.c > > +++ b/drivers/hwmon/hp_accel.c > > @@ -328,9 +328,9 @@ static int lis3lv02d_remove(struct acpi_device *device, int type) > > lis3lv02d_joystick_disable(); > > lis3lv02d_poweroff(&lis3_dev); > > > > - flush_work(&hpled_led.work); > > led_classdev_unregister(&hpled_led.led_classdev); > > - > > + flush_work(&hpled_led.work); > > + > > return lis3lv02d_remove_fs(&lis3_dev); > > } > > > > You are adding trailing white space. Please don't. Use > scripts/checkpatch.pl to check your patches before you send them. Thank you. A corrected version is on its way. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |