Prev: [patch] mfd: off by one calculating size
Next: [PATCH 2/2] HID:HID-NTRIG update ntrig_event function
From: Dan Carpenter on 22 Mar 2010 08:20
The size calculation is not correct. It should be end - start + 1.
Use resource_size() to caculate it.

Signed-off-by: Dan Carpenter <error27(a)gmail.com>
---
This was found by a static checker and I don't have the hardware to
test it. Please review carefully.

diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
index 75285d3..c91a7f7 100644
--- a/drivers/video/pxa168fb.c
+++ b/drivers/video/pxa168fb.c
@@ -668,7 +668,7 @@ static int __init pxa168fb_probe(struct platform_device *pdev)
/*
* Map LCD controller registers.
*/
- fbi->reg_base = ioremap_nocache(res->start, res->end - res->start);
+ fbi->reg_base = ioremap_nocache(res->start, resource_size(res));
if (fbi->reg_base == NULL) {
ret = -ENOMEM;
goto failed;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [patch] mfd: off by one calculating size
Next: [PATCH 2/2] HID:HID-NTRIG update ntrig_event function