perf: Add DWARF register lookup for SH
in [Kernel]
|
Prev: [PATCH] eeepc-laptop: fix hotplug_disabled module_param permissions
Next: writeback: dont redirty tail an inode with dirty pages
From: Masami Hiramatsu on 11 Jul 2010 22:00 Matt Fleming wrote: > Implement get_arch_regstr() for SH so that, given a DWARF register > number, the corresponding symbolic name of that register can be looked > up. OK, the patch itself looks good, but I don't know whether SH kernel supports KPROBE_EVENT which is required for perf-probe. Or, SH kernel repository already has it? Thank you, > > Signed-off-by: Matt Fleming <matt(a)console-pimps.org> > --- > tools/perf/arch/sh/Makefile | 4 ++ > tools/perf/arch/sh/util/dwarf-regs.c | 55 ++++++++++++++++++++++++++++++++++ > 2 files changed, 59 insertions(+), 0 deletions(-) > create mode 100644 tools/perf/arch/sh/Makefile > create mode 100644 tools/perf/arch/sh/util/dwarf-regs.c > > diff --git a/tools/perf/arch/sh/Makefile b/tools/perf/arch/sh/Makefile > new file mode 100644 > index 0000000..15130b5 > --- /dev/null > +++ b/tools/perf/arch/sh/Makefile > @@ -0,0 +1,4 @@ > +ifndef NO_DWARF > +PERF_HAVE_DWARF_REGS := 1 > +LIB_OBJS += $(OUTPUT)arch/$(ARCH)/util/dwarf-regs.o > +endif > diff --git a/tools/perf/arch/sh/util/dwarf-regs.c b/tools/perf/arch/sh/util/dwarf-regs.c > new file mode 100644 > index 0000000..a11edb0 > --- /dev/null > +++ b/tools/perf/arch/sh/util/dwarf-regs.c > @@ -0,0 +1,55 @@ > +/* > + * Mapping of DWARF debug register numbers into register names. > + * > + * Copyright (C) 2010 Matt Fleming <matt(a)console-pimps.org> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. > + * > + */ > + > +#include <libio.h> > +#include <dwarf-regs.h> > + > +/* > + * Generic dwarf analysis helpers > + */ > + > +#define SH_MAX_REGS 18 > +const char *sh_regs_table[SH_MAX_REGS] = { > + "r0", > + "r1", > + "r2", > + "r3", > + "r4", > + "r5", > + "r6", > + "r7", > + "r8", > + "r9", > + "r10", > + "r11", > + "r12", > + "r13", > + "r14", > + "r15", > + "pc", > + "pr", > +}; > + > +/* Return architecture dependent register string (for kprobe-tracer) */ > +const char *get_arch_regstr(unsigned int n) > +{ > + return (n <= SH_MAX_REGS) ? sh_regs_table[n] : NULL; > +} -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Matt Fleming on 12 Jul 2010 02:30 On Mon, 12 Jul 2010 10:54:43 +0900, Masami Hiramatsu <masami.hiramatsu.pt(a)hitachi.com> wrote: > Matt Fleming wrote: > > Implement get_arch_regstr() for SH so that, given a DWARF register > > number, the corresponding symbolic name of that register can be looked > > up. > > OK, the patch itself looks good, but I don't know whether SH kernel > supports KPROBE_EVENT which is required for perf-probe. Or, SH kernel > repository already has it? No, SH doesn't support KPROBE_EVENT yet. It's on my list of things to do. However, this patch also stops the "DWARF register mappings have not been defined" warning when building perf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Paul Mundt on 12 Jul 2010 02:50 On Mon, Jul 12, 2010 at 07:23:44AM +0100, Matt Fleming wrote: > On Mon, 12 Jul 2010 10:54:43 +0900, Masami Hiramatsu <masami.hiramatsu.pt(a)hitachi.com> wrote: > > Matt Fleming wrote: > > > Implement get_arch_regstr() for SH so that, given a DWARF register > > > number, the corresponding symbolic name of that register can be looked > > > up. > > > > OK, the patch itself looks good, but I don't know whether SH kernel > > supports KPROBE_EVENT which is required for perf-probe. Or, SH kernel > > repository already has it? > > No, SH doesn't support KPROBE_EVENT yet. It's on my list of things to > do. However, this patch also stops the "DWARF register mappings have not > been defined" warning when building perf. It does now, by virtue of HAVE_REGS_AND_STACK_ACCESS_API. The initial support for this was checked in on June 14th, so you should be able to use it already as long as you're working with current HEAD. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Matt Fleming on 12 Jul 2010 04:20 On Mon, Jul 12, 2010 at 03:41:26PM +0900, Paul Mundt wrote: > On Mon, Jul 12, 2010 at 07:23:44AM +0100, Matt Fleming wrote: > > > > No, SH doesn't support KPROBE_EVENT yet. It's on my list of things to > > do. However, this patch also stops the "DWARF register mappings have not > > been defined" warning when building perf. > > It does now, by virtue of HAVE_REGS_AND_STACK_ACCESS_API. The initial > support for this was checked in on June 14th, so you should be able to > use it already as long as you're working with current HEAD. Oh, whoops, I must have been thinking of something else. Thanks Paul! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Masami Hiramatsu on 12 Jul 2010 05:00
Paul Mundt wrote: > On Mon, Jul 12, 2010 at 07:23:44AM +0100, Matt Fleming wrote: >> On Mon, 12 Jul 2010 10:54:43 +0900, Masami Hiramatsu <masami.hiramatsu.pt(a)hitachi.com> wrote: >>> Matt Fleming wrote: >>>> Implement get_arch_regstr() for SH so that, given a DWARF register >>>> number, the corresponding symbolic name of that register can be looked >>>> up. >>> OK, the patch itself looks good, but I don't know whether SH kernel >>> supports KPROBE_EVENT which is required for perf-probe. Or, SH kernel >>> repository already has it? >> No, SH doesn't support KPROBE_EVENT yet. It's on my list of things to >> do. However, this patch also stops the "DWARF register mappings have not >> been defined" warning when building perf. > > It does now, by virtue of HAVE_REGS_AND_STACK_ACCESS_API. The initial > support for this was checked in on June 14th, so you should be able to > use it already as long as you're working with current HEAD. Wow, that's great! :) Thanks! -- Masami HIRAMATSU 2nd Research Dept. Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt(a)hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |