Prev: [PATCH 1/2] Removing dead CONFIG_PARAVIRT_GUEST_ASM_CLOBBER_CHECK
Next: init: Fix race between init and kthreadd -v2
From: Arnaldo Carvalho de Melo on 28 Jun 2010 10:00 Em Mon, Jun 28, 2010 at 11:29:41AM +0530, Srikar Dronamraju escreveu: > > perf: Dont adjust symbols on name lookup > > Adjusting symbols is not needed if we are searching by name even > if the symbols correspond to user space objects. > Infact if we adjust and search symbols by name, we get incorrect > results. I'll review this, but it would be nice to explain why we get incorrect results, as we may be just fixing a symptom of some other problem. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Srikar Dronamraju on 29 Jun 2010 14:00
> > > > perf: Dont adjust symbols on name lookup > > > > Adjusting symbols is not needed if we are searching by name even > > if the symbols correspond to user space objects. > > Infact if we adjust and search symbols by name, we get incorrect > > results. > > I'll review this, but it would be nice to explain why we get incorrect > results, as we may be just fixing a symptom of some other problem. > You are right. I removed this patch and still see no change in behaviour. Earlier without this patch, I saw that perf report would show a wrong function name(around 2.6.34-rc5 and I carried it to 2.6.35-tip). However the number of events recorded would correspond to the probed function. Since I am seeing correct behaviour even without this patch, I will drop this patch in the next posting of the patchset. -- Thanks Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |