From: Frederic Weisbecker on
On Wed, Jun 23, 2010 at 09:17:53AM +0900, Nobuhiro Iwamatsu wrote:
> "struct regs" was set to argument of perf_arch_fetch_caller_regs.
> "struct pt_regs" is correct.
>
> Cc: Frederic Weisbecker <fweisbec(a)gmail.com>
> Cc: Paul Mackerras <paulus(a)samba.org>
> Cc: David Miller <davem(a)davemloft.net>
> Cc: Ingo Molnar <mingo(a)elte.hu>
> Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com>



Acked-by: Frederic Weisbecker <fweisbec(a)gmail.com>

This may fix CONFIG_PERF_EVENTS=y with archs that don't implement
perf_arch_fetch_caller_regs, namely ARM, alpha, frv, parisc, s390 and sh.

Ingo, can you please queue this for .36? (it only fixes perf/core)

Thanks.




> ---
> include/linux/perf_event.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 9073bde..b65736d 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -934,7 +934,7 @@ extern void __perf_sw_event(u32, u64, int, struct
> pt_regs *, u64);
>
> #ifndef perf_arch_fetch_caller_regs
> static inline void
> -perf_arch_fetch_caller_regs(struct regs *regs, unsigned long ip) { }
> +perf_arch_fetch_caller_regs(struct pt_regs *regs, unsigned long ip) { }
> #endif
>
> /*
> --
> 1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Frederic Weisbecker on
On Wed, Jun 23, 2010 at 09:17:53AM +0900, Nobuhiro Iwamatsu wrote:
> "struct regs" was set to argument of perf_arch_fetch_caller_regs.
> "struct pt_regs" is correct.
>
> Cc: Frederic Weisbecker <fweisbec(a)gmail.com>
> Cc: Paul Mackerras <paulus(a)samba.org>
> Cc: David Miller <davem(a)davemloft.net>
> Cc: Ingo Molnar <mingo(a)elte.hu>
> Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj(a)renesas.com>



Actually I'm queuing it, as I have other patches for perf in queue.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/