Prev: [GIT]: Networking
Next: __devinitdata, __devinitconst and const?
From: Ingo Molnar on 6 Dec 2009 07:00

* OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp> wrote:

> Hi,
>
> Update "struct trace_entry" to match with current one. And remove
> "size" field from it.
>
> If it has "size", it become cause of alignment mismatch of structure
> with kernel.
>
> Signed-off-by: OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>
> ---
>
> tools/perf/builtin-timechart.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)

Just curious, have you tested timechart functionality after having done
this change - does it still work fine for you?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: OGAWA Hirofumi on 6 Dec 2009 07:30
Ingo Molnar <mingo(a)elte.hu> writes:

>> Yes. Rather, it doesn't work without this. (Without patch, it provide
>> svg output, but it doesn't provide correct sched state. And this issue
>> is only 64bit arch.)

[...]

> ok - thanks for the confirmation!

BTW, more correct fix would be using raw_filed_value() or something, so
it would become more robust. But, sorry, I didn't.

Thanks.
--
OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [GIT]: Networking
Next: __devinitdata, __devinitconst and const?