Prev: c2port: fix device_create() return value check
Next: drivers/net: drop redundant memset
From: Stephen Rothwell on 15 Mar 2010 18:40
Hi Frederic,

On Mon, 15 Mar 2010 23:17:22 +0100 Frederic Weisbecker <fweisbec(a)gmail.com> wrote:
>
> perf_arch_fetch_caller_regs() is exported for the overriden x86
> version, but not for the generic weak version.
> As a general rule, weak functions should have their symbol exported
^
"not"

> in the same file they are defined.
>
> So let's export it on trace_event_perf.c as it is used by trace
> events only.

Otherwise, looks good (though I haven't tested it).

--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
 | 
Pages: 1
Prev: c2port: fix device_create() return value check
Next: drivers/net: drop redundant memset