perf: Round robin groups of events using list_rotate_left()
in [Kernel]
|
Prev: 2.6.33-rc3 -- INFO: possible recursive locking -- (s_active){++++.+}, at: [<c10d2941>] sysfs_hash_and_remove+0x3d/0x4f
Next: perf: Round robin groups of events using list_rotate_left()
From: Peter Zijlstra on 14 Jan 2010 07:30 On Sun, 2010-01-10 at 02:38 +0100, Frederic Weisbecker wrote: > This is more proper that doing it through a list_for_each_entry() > that breaks after the first entry. > > Signed-off-by: Frederic Weisbecker <fweisbec(a)gmail.com> > Cc: Peter Zijlstra <peterz(a)infradead.org> > Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> > Cc: Paul Mackerras <paulus(a)samba.org> > --- > + list_rotate_left(&ctx->pinned_groups); > + list_rotate_left(&ctx->flexible_groups); Just wondering, pinned events were supposed to be on the pmu at all times, right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Peter Zijlstra on 14 Jan 2010 07:40
On Thu, 2010-01-14 at 13:29 +0100, Frederic Weisbecker wrote: > > But there is a subsequent patch in the same set > that removes the rotating of pinned groups. ok, let me read on ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |