perf events: Fix false positive build warning with older GCC's
in [Kernel]
|
Prev: [PATCH tip/core/urgent 1/2] rcu: local_irq_disable() also delimits RCU_SCHED read-site critical sections
Next: pull request: wireless-2.6 2010-03-18
From: Masami Hiramatsu on 18 Mar 2010 16:10 tip-bot for Ingo Molnar wrote: > Commit-ID: 55632770d7298835645489828af87f854c47749c > Gitweb: http://git.kernel.org/tip/55632770d7298835645489828af87f854c47749c > Author: Ingo Molnar <mingo(a)elte.hu> > AuthorDate: Thu, 18 Mar 2010 16:51:16 +0100 > Committer: Ingo Molnar <mingo(a)elte.hu> > CommitDate: Thu, 18 Mar 2010 17:03:24 +0100 > > perf events: Fix false positive build warning with older GCC's > > gcc 4.2.1 produces: > > util/probe-event.c: In function 'add_perf_probe_events': > util/probe-event.c:883: warning: 'tev' may be used uninitialized in this function > make: *** [util/probe-event.o] Error 1 > > Newer GCCs get this right. > > To work it around, initialize the variable to NULL so that older GCCs see > it as initialized too. Hmm, indeed. this code implies that ntevs > 0, it seems that we'd better check it first (e.g. 'if(ntevs <= 0) return;') too. Thank you, > > Cc: Masami Hiramatsu <mhiramat(a)redhat.com> > Cc: Frederic Weisbecker <fweisbec(a)gmail.com> > Cc: Arnaldo Carvalho de Melo <acme(a)redhat.com> > Cc: Paul Mackerras <paulus(a)samba.org> > Cc: Mike Galbraith <efault(a)gmx.de> > Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl> > LKML-Reference: <20100316220612.32050.33806.stgit(a)localhost6.localdomain6> > Signed-off-by: Ingo Molnar <mingo(a)elte.hu> > --- > tools/perf/util/probe-event.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index f333269..c6603f3 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -880,7 +880,7 @@ static void __add_kprobe_trace_events(struct perf_probe_event *pev, > int ntevs, bool allow_suffix) > { > int i, fd; > - struct kprobe_trace_event *tev; > + struct kprobe_trace_event *tev = NULL; > char buf[64]; > const char *event, *group; > struct strlist *namelist; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami Hiramatsu e-mail: mhiramat(a)redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |