perf probe: Don't compile CFI related code if elfutils is old
in [Kernel]
|
Prev: [PATCH 1/1] staging: hv: Optimize adj_guesttime function and add more detailed comments
Next: [PATCHv3 2.6.34-rc7 1/3] mxc: gadget: remove 60mhz clock requirement for freescale mx51 usb core
From: Robert Richter on 10 May 2010 14:40 On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote: > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu: > > Check elfutils version, and if it is old don't compile > > CFI analysis code. This allows to compile perf with > > old elfutils. > > _ELFUTILS_PREREQ was introduced in: > > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60 > Author: Roland McGrath <roland(a)redhat.com> > Date: Tue Dec 16 17:03:03 2008 -0800 > > Which was released in elfutils 0.138, guess this is coverage enough? > Richard, which version is in your machine? Right, this does not work, I am using 0.131. As expected, "_ELFUTILS_PREREQ" is not defined: gcc -o builtin-probe.o -c -ggdb3 -Wall -Wextra -std=gnu99 -Werror -O6 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Wformat-y2k -Wshadow -Winit-self -Wpacked -Wredundant-decls -Wstack-protector -Wstrict-aliasing=3 -Wswitch-default -Wswitch-enum -Wno-system-headers -Wundef -Wvolatile-register-var -Wwrite-strings -Wbad-function-cast -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wstrict-prototypes -Wdeclaration-after-statement -fstack-protector-all -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iutil/include -Iarch/x86/include -I/usr/include/elfutils -DDWARF_SUPPORT -DNO_NEWT_SUPPORT -DNO_LIBPERL -DSHA1_HEADER='<openssl/sha.h>' builtin-probe.c In file included from builtin-probe.c:43: util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined util/probe-finder.h:47:21: error: missing binary operator before token "(" make: *** [builtin-probe.o] Error 1 Why not create a compile test as for NO_DWARF in tools/perf/Makefile? -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter(a)amd.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnaldo Carvalho de Melo on 10 May 2010 15:00 Em Mon, May 10, 2010 at 08:36:54PM +0200, Robert Richter escreveu: > On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote: > > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu: > > > Check elfutils version, and if it is old don't compile CFI > > > analysis code. This allows to compile perf with old elfutils. > > _ELFUTILS_PREREQ was introduced in: > > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60 > > Author: Roland McGrath <roland(a)redhat.com> > > Date: Tue Dec 16 17:03:03 2008 -0800 > > Which was released in elfutils 0.138, guess this is coverage enough? > > Richard, which version is in your machine? > Right, this does not work, I am using 0.131. As expected, > "_ELFUTILS_PREREQ" is not defined: > util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined > util/probe-finder.h:47:21: error: missing binary operator before token "(" > make: *** [builtin-probe.o] Error 1 > Why not create a compile test as for NO_DWARF in tools/perf/Makefile? Right, that would be better. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Arnaldo Carvalho de Melo on 10 May 2010 15:20 Em Mon, May 10, 2010 at 02:57:34PM -0400, Masami Hiramatsu escreveu: > Hmm, ok, version.h is also introduced at the same time. > > # git log ./config/version.h.in > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60 > Author: Roland McGrath <roland(a)redhat.com> > Date: Tue Dec 16 17:03:03 2008 -0800 > > Install elfutils/version.h header for library compatibility checking. > > So, I think we'd better set NO_DWARF if the elfutils > is older than 0.138, since we can't check API compatibility > easily. Well, for that you can just add some of the code you ifdefed in this patch into the tools/perf/Makefile test, or better, duplicate the test, including just the CPI stuff in the new test, and then set NO_DWARF_CFI and use it as the ifdef condition :-) - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mark Wielaard on 11 May 2010 04:20 On Mon, 2010-05-10 at 15:19 -0400, Masami Hiramatsu wrote: > Hm, I'd like to add just '#ifndef _ELFUTILS_PREREQ;#error;#endif' to > NO_DWARF checking in Makefile, because it's easier to expand to another > API dependency. You might want to check systemtap/dwarf-wrappers.h which handles missing _ELFUTILS_PREREQ, so you can use it as if it is always defined. That said, 0.138 is pretty old (latest is 0.147), so just requiring something fresh might not be a bad thing. Cheers, Mark -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Robert Richter on 18 May 2010 05:40
On 17.05.10 21:57:38, tip-bot for Masami Hiramatsu wrote: > Commit-ID: 7752f1b096e13991f20b59fd11ba73da3809d93c > Gitweb: http://git.kernel.org/tip/7752f1b096e13991f20b59fd11ba73da3809d93c > Author: Masami Hiramatsu <mhiramat(a)redhat.com> > AuthorDate: Mon, 10 May 2010 13:12:07 -0400 > Committer: Arnaldo Carvalho de Melo <acme(a)redhat.com> > CommitDate: Mon, 17 May 2010 22:13:51 -0300 > > perf probe: Don't compile CFI related code if elfutils is old > > Check elfutils version, and if it is old don't compile CFI analysis code. This > allows to compile perf with old elfutils. > > Signed-off-by: Masami Hiramatsu <mhiramat(a)redhat.com> > Tested-by: Stephane Eranian <eranian(a)google.com> > Reported-by: Robert Richter <robert.richter(a)amd.com> > Cc: Ingo Molnar <mingo(a)elte.hu> > LKML-Reference: <20100510171207.26029.97604.stgit(a)localhost6.localdomain6> > Signed-off-by: Arnaldo Carvalho de Melo <acme(a)redhat.com> > --- I think this patch is not needed as we came up with an alternative solution with commit: 6b3c4ef perf probe: Check older elfutils and set NO_DWARF -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter(a)amd.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |