From: Arnaldo Carvalho de Melo on
Em Mon, Jul 05, 2010 at 08:07:30PM +0200, Conny Seidel escreveu:
> make version 3.80 doesn't support "else ifdef" on the same line, also it
> doesn't support unindented nested constructs.
>
> Build fails with:
> Makefile:608: Extraneous text after `else' directive
> Makefile:611: *** only one `else' per conditional. Stop.
>
> This patch fixes the build for make 3.80.
>
> Signed-off-by: Conny Seidel <conny.seidel(a)amd.com>

I got this on my tree, will push to Ingo after I get the perf probe
changes tested.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on

* Arnaldo Carvalho de Melo <acme(a)infradead.org> wrote:

> From: Conny Seidel <conny.seidel(a)amd.com>
>
> make version 3.80 doesn't support "else ifdef" on the same line, also it
> doesn't support unindented nested constructs.
>
> Build fails with:
> Makefile:608: Extraneous text after `else' directive
> Makefile:611: *** only one `else' per conditional. Stop.
>
> This patch fixes the build for make 3.80.

Since 3.81 is the latest Make version and 3.80 is just one step before that,
shouldnt we cherry-pick this into perf/urgent? (or is current upstream
unaffected?)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Conny Seidel on
On Tue, 6 Jul 2010 02:59:04 -0400
Ingo Molnar <mingo(a)elte.hu> wrote:

>
>* Arnaldo Carvalho de Melo <acme(a)infradead.org> wrote:
>
>> From: Conny Seidel <conny.seidel(a)amd.com>
>>
>> make version 3.80 doesn't support "else ifdef" on the same line,
>> also it doesn't support unindented nested constructs.
>>
>> Build fails with:
>> Makefile:608: Extraneous text after `else' directive
>> Makefile:611: *** only one `else' per conditional. Stop.
>>
>> This patch fixes the build for make 3.80.
>
>Since 3.81 is the latest Make version and 3.80 is just one step before
>that, shouldnt we cherry-pick this into perf/urgent? (or is current
>upstream unaffected?)

Current upstream is also affected. So it makes sense to put it in
perf/urgent.

>Thanks,
>
> Ingo
>

regards,
Conny

##
##################################################################
# Email : conny.seidel(a)amd.com GnuPG-Key : 0xA6AB055D #
# Fingerprint: 17C4 5DB2 7C4C C1C7 1452 8148 F139 7C09 A6AB 055D #
##################################################################
# Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach #
# General Managers: Alberto Bozzo, Andrew Bowd #
# Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen #
# HRB Nr. 43632 #
##################################################################