Prev: Heute noch Geld verdienen?
Next: oom-kill: add lowmem usage aware oom kill handling
From: Mike Galbraith on 21 Jan 2010 10:00
On Thu, 2010-01-21 at 12:49 -0200, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 21, 2010 at 03:28:32PM +0100, Mike Galbraith escreveu:
> > On Thu, 2010-01-21 at 10:22 -0200, Arnaldo Carvalho de Melo wrote:
> >
> > > Can you check if this one helps?
> >
> > Made interrupt count correct, but symbols aren't mapped after the task
> > forks it seems. At least, in event__preprocess_sample(), after
> > thread__find_addr_location(), al->map is NULL a LOT.
>
> Try this one on top of the previous one:
>
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 8b04988..2227b84 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -975,6 +975,10 @@ static int event__process(event_t *event, struct perf_session *session)
> case PERF_RECORD_MMAP:
> event__process_mmap(event, session);
> break;
> + case PERF_RECORD_FORK:
> + case PERF_RECORD_EXIT:
> + event__process_task(event, session);
> + break;
> default:
> break;
> }

Yup. All better.

I figured that had to to be tied in from rummaging around earlier.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Arnaldo Carvalho de Melo on 21 Jan 2010 10:10
Em Thu, Jan 21, 2010 at 03:56:12PM +0100, Mike Galbraith escreveu:
> On Thu, 2010-01-21 at 12:49 -0200, Arnaldo Carvalho de Melo wrote:
> > + case PERF_RECORD_FORK:
> > + case PERF_RECORD_EXIT:
> > + event__process_task(event, session);
> > + break;
> > default:
> > break;
> > }
>
> Yup. All better.
>
> I figured that had to to be tied in from rummaging around earlier.

Thanks for testing!

I'm pushing these two fixes with your Tested-by tags.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2
Prev: Heute noch Geld verdienen?
Next: oom-kill: add lowmem usage aware oom kill handling