Prev: [PATCH 5/7] perf trace: use long_size from trace-event-read
Next: [PATCH 1/7] perf trace: Defensive programming
From: Ian Munsie on 13 May 2010 02:10
This patch series fixes several issues with perf trace relating to the size of a long.

The first issue fixed by patch #2 is an assumption that tracepoints with arrays
as part of their output (for instance, raw_syscalls:sys_enter) that the size of
each element within the array is a long size. Due to further problems fixed by
patches #3 through #5, the long_size was not even being set in the
trace-event-parse.c file, and as a result the code was previously treating the
array elements as 0 size.

Patch #6 fixes issues where printing the values of pointers and longs from
64bit kernels were being truncated if perf was compiled as 32bit. This
obviously effects tracepoints with a "%p" or "%ld" in their output format, but
also affects the printout of the location of kprobes.

Patches #1 and #7 apply good software engineering practice to help spot future
regressions of these issues.

Thanks,
-Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/7] perf trace: use long_size from trace-event-read
Next: [PATCH 1/7] perf trace: Defensive programming