Prev: [PATCH] lirc: use unlocked_ioctl
Next: [PATCH 2/4] rtmutex: add BUG_ON if a task attempts to block on two locks
From: Serge E. Hallyn on 9 Jul 2010 18:20
Quoting Eric W. Biederman (ebiederm(a)xmission.com):
....
> @@ -2742,13 +2743,13 @@ void proc_flush_task(struct task_struct *task)
>
> for (i = 0; i <= pid->level; i++) {
> upid = &pid->numbers[i];
> - proc_flush_task_mnt(upid->ns->proc_mnt, upid->nr,
> - tgid->numbers[i].nr);
> - }
> + mnt = get_proc_mnt(upid->ns);

....

> -int pid_ns_prepare_proc(struct pid_namespace *ns)
> +struct vfsmount *get_proc_mnt(struct pid_namespace *ns)
> {
> - struct vfsmount *mnt;
> -
> - mnt = kern_mount_data(&proc_fs_type, ns);
> - if (IS_ERR(mnt))
> - return PTR_ERR(mnt);
> -
> - return 0;
> + return kern_mount_data(&proc_fs_type, ns);

Uh, that looks like it's got to be a *huge* hit. Each kern_mount_data()
will at least alloc space for a vfsmnt and proc_fs_type->name. Once for
each pid level of each exiting task.

(Or am I misreading?)

-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] lirc: use unlocked_ioctl
Next: [PATCH 2/4] rtmutex: add BUG_ON if a task attempts to block on two locks