powerpc/85xx: Add MChk handler for SRIO port
in [Kernel]
|
Prev: [tip:perf/core] perf tools: Don't keep unreferenced maps when unmaps are detected
Next: linux-next: Tree for August 3
From: Bounine, Alexandre on 5 Aug 2010 13:30 Below is a copy of Leo's message with pointers to the patches. Alex. >Subject: [PATCH] RapidIO,powerpc/85xx: remove MCSR_MASK in fsl_rio > >Fixes compile problem caused by MCSR_MASK removal from book-E definitions. Hi Alex, Only with your patch, there will still be problem on SRIO platforms other than MPC85xx. I have posted a patch series to fix this together with several compatibility issues a month before. http://patchwork.ozlabs.org/patch/56135/ http://patchwork.ozlabs.org/patch/56136/ http://patchwork.ozlabs.org/patch/56138/ http://patchwork.ozlabs.org/patch/56137/ Can anyone pick the patch series quickly as currently there is a compile error when SRIO is enabled. - Leo > -----Original Message----- > From: Michael Neuling [mailto:mikey(a)neuling.org] > Sent: Wednesday, August 04, 2010 11:34 PM > To: Bounine, Alexandre > Cc: Timur Tabi; Alexandre Bounine; linuxppc-dev(a)lists.ozlabs.org; linux-kernel(a)vger.kernel.org; > thomas.moll(a)sysgo.com; Kumar Gala > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port > > > > In message <0CE8B6BE3C4AD74AB97D9D29BD24E552011430BC(a)CORPEXCH1.na.ads.idt.com> you wrote: > > Yang Li pointed to these patches in his post from July 23, 2010. > > It would be nice to have these patches in mainline code.=20 > > This is still broken in Kumar's latest tree. Do you guys wanna repost > them so Kumar can pick them up easily? > > Mikey > > > > > > -----Original Message----- > > > From: timur.tabi(a)gmail.com [mailto:timur.tabi(a)gmail.com] On Behalf Of > > Timur Tabi > > > Sent: Tuesday, August 03, 2010 9:02 AM > > > To: Bounine, Alexandre > > > Cc: Michael Neuling; Alexandre Bounine; linuxppc-dev(a)lists.ozlabs.org; > > linux-kernel(a)vger.kernel.org; > > > thomas.moll(a)sysgo.com; Kumar Gala > > > Subject: Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO > > port > > >=20 > > > On Tue, Aug 3, 2010 at 7:17 AM, Bounine, Alexandre > > > <Alexandre.Bounine(a)idt.com> wrote: > > > > This happened after change to book-e definitions. > > > > There are patches that address this issue. > > >=20 > > > And those patches should have been applied before 2.6.35 was released. > > > Someone dropped the ball. 2.6.35 is broken for a number of PowerPC > > > boards: > > >=20 > > > $ make mpc85xx_defconfig > > > .... > > > $ make > > > .... > > > CC arch/powerpc/sysdev/fsl_rio.o > > > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception': > > > arch/powerpc/sysdev/fsl_rio.c:248: error: 'MCSR_MASK' undeclared > > > (first use in this function) > > > arch/powerpc/sysdev/fsl_rio.c:248: error: (Each undeclared identifier > > > is reported only once > > > arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears > > in.) > > > make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 > > >=20 > > > -- > > > Timur Tabi > > > Linux kernel developer at Freescale > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Kumar Gala on 5 Aug 2010 14:00 On Aug 5, 2010, at 12:25 PM, Bounine, Alexandre wrote: > Below is a copy of Leo's message with pointers to the patches. > > Alex. > >> Subject: [PATCH] RapidIO,powerpc/85xx: remove MCSR_MASK in fsl_rio >> >> Fixes compile problem caused by MCSR_MASK removal from book-E > definitions. > > Hi Alex, > > Only with your patch, there will still be problem on SRIO platforms > other than MPC85xx. > > I have posted a patch series to fix this together with several > compatibility issues a month before. > > http://patchwork.ozlabs.org/patch/56135/ > http://patchwork.ozlabs.org/patch/56136/ > http://patchwork.ozlabs.org/patch/56138/ > http://patchwork.ozlabs.org/patch/56137/ > > > Can anyone pick the patch series quickly as currently there is a compile > error when SRIO is enabled. > > - Leo I'm looking at this now and wondering what we added the mcheck handler for in the first place and what its trying to accomplish. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Bounine, Alexandre on 5 Aug 2010 14:20
> I'm looking at this now and wondering what we added the mcheck handler for in the first place and what > its trying to accomplish. > > - k This protects system from hanging if RIO link fails or enters error state. In some situations following maintenance read may initiate link recovery from error state. As it is now, MCheck mostly prevents system from hanging, but it also adds sense to return status of maintenance read routine. I am using return status in my new set of patches to check if RIO link is valid during error recovery. Alex. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |