Prev: [PATCH] hwmon: sht15: Fix sht15_calc_temp interpolation function
Next: [PATCH] x86, cacheinfo: Turn off L3 cache index disable feature in virtualized environments
From: Frans Pop on 1 Apr 2010 10:50
Jan Kiszka wrote:
> - "proc_file_read: Apparent buffer overflow!\n");
> + "proc_file_read: Apparent buffer "
> + "overflow reading \"%s\"!\n",
> + file->f_path.dentry->d_name.name);

I think it would be good to keep "overflow" on the first line as that
may be what people will grep the source for. And maybe use single quotes
around the file name. So:

+ "proc_file_read: Apparent buffer overflow "
+ "reading '%s'!\n",
+ file->f_path.dentry->d_name.name);

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Alexey Dobriyan on 2 Apr 2010 02:30
On Thu, Apr 1, 2010 at 4:09 PM, Jan Kiszka <jan.kiszka(a)siemens.com> wrote:
> This can help identifying the buggy read_proc handler.

->read_proc is going to be removed, so there is no point.

> - � � � � � � � � � � � � � � � � � � �"proc_file_read: Apparent buffer overflow!\n");
> + � � � � � � � � � � � � � � � � � � �"proc_file_read: Apparent buffer "
> + � � � � � � � � � � � � � � � � � � �"overflow reading \"%s\"!\n",
> + � � � � � � � � � � � � � � � � � � �file->f_path.dentry->d_name.name);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jan Kiszka on 6 Apr 2010 12:50
Alexey Dobriyan wrote:
> On Thu, Apr 1, 2010 at 4:09 PM, Jan Kiszka <jan.kiszka(a)siemens.com> wrote:
>> This can help identifying the buggy read_proc handler.
>
> ->read_proc is going to be removed, so there is no point.

OK. What is the planned kernel release or date?

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] hwmon: sht15: Fix sht15_calc_temp interpolation function
Next: [PATCH] x86, cacheinfo: Turn off L3 cache index disable feature in virtualized environments