Prev: request_firmware API exhaust memory
Next: rcu: shrink rcutiny by making synchronize_rcu_bh() be inline
From: David Howells on 20 Apr 2010 06:20
Paul E. McKenney <paulmck(a)linux.vnet.ibm.com> wrote:

> +void rcu_scheduler_starting(void)
> +{
> + WARN_ON(nr_context_switches() > 0);
> + rcu_scheduler_active = 1;
> +}

Since rcu_scheduler_active is a global variable, does it make sense to make
this an inline function in the header file?

It looks decidedly odd in its own include file as you've done it. Wouldn't
the right way to do this be to split it into its own .c file and conditionally
compile it in the Makefile?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: request_firmware API exhaust memory
Next: rcu: shrink rcutiny by making synchronize_rcu_bh() be inline