regulator: max8660 - fix a memory leak in max8660_remove()
in [Kernel]
|
Prev: lib: vsprintf: added a put_dec() test and benchmark tool
Next: regulator: max1586 - fix a memory leak in max1586_pmic_remove()
From: Wolfram Sang on 6 Aug 2010 04:50 On Fri, Aug 06, 2010 at 01:35:27PM +0800, Axel Lin wrote: > In max8660_probe(), we allocate memory for max660. Typo: max8660 > In max8660_remove(), current implementation only free rdev > which is a member of struct max8660. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max660 to i2c clientdata, > and properly kfree(max8660) in max8660_remove(). These two lines could go away IMHO as they are directly visible from the code. Still, no real need for a resend from my side. > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Wolfram Sang <w.sang(a)pengutronix.de> Thanks for catching that! -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
From: Mark Brown on 6 Aug 2010 07:30 On Fri, Aug 06, 2010 at 01:35:27PM +0800, Axel Lin wrote: > In max8660_probe(), we allocate memory for max660. > In max8660_remove(), current implementation only free rdev > which is a member of struct max8660. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max660 to i2c clientdata, > and properly kfree(max8660) in max8660_remove(). > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Liam Girdwood on 9 Aug 2010 04:40
On Fri, 2010-08-06 at 13:35 +0800, Axel Lin wrote: > In max8660_probe(), we allocate memory for max660. > In max8660_remove(), current implementation only free rdev > which is a member of struct max8660. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max660 to i2c clientdata, > and properly kfree(max8660) in max8660_remove(). > > Signed-off-by: Axel Lin <axel.lin(a)gmail.com> > --- > drivers/regulator/max8660.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > Applied. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |