Prev: [PATCHv9 2.6.35-rc4-tip 6/13] uprobes: X86 support for Uprobes
Next: [PATCHv9 2.6.35-rc4-tip 12/13] [RFC] perf: Show Potential probe points.
From: Mark Brown on 12 Jul 2010 06:50
On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:

> +
> + /* Does DCDC high or the low register defines output voltage? */
> + bool defdcdc_high;

This should probably be "defdcdc_default" or something. Presumably the
line can also be wired to a GPIO and changed at runtime (otherwise the
feature seems at best odd) and if support for that is implemented then
this will change from being a static configuration in the platform data
to something configured dynamically so the name would no longer make
sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Nori, Sekhar on 12 Jul 2010 06:50

Hi Mark,

On Mon, Jul 12, 2010 at 16:10:45, Mark Brown wrote:
> On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:
>
> > +
> > + /* Does DCDC high or the low register defines output voltage? */
> > + bool defdcdc_high;
>
> This should probably be "defdcdc_default" or something. Presumably the
> line can also be wired to a GPIO and changed at runtime (otherwise the
> feature seems at best odd) and if support for that is implemented then
> this will change from being a static configuration in the platform data
> to something configured dynamically so the name would no longer make
> sense.

Quite right, it should be possible to change that line at runtime - though
none of the existing boards use that flexibility. Will change the name as
you have suggested.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Mark Brown on 12 Jul 2010 08:30
On Mon, Jul 12, 2010 at 05:54:06PM +0530, Sekhar Nori wrote:
> From: Anuj Aggarwal <anuj.aggarwal(a)ti.com>
>
> In TPS6507x, depending on the status of DEFDCDC{2,3} pin either
> DEFDCDC{2,3}_LOW or DEFDCDC{2,3}_HIGH register needs to be read or
> programmed to change the output voltage.
>
> The current driver assumes DEFDCDC{2,3} pins are always tied low
> and thus operates only on DEFDCDC{2,3}_LOW register. This need
> not always be the case (as is found on OMAP-L138 EVM).
>
> Unfortunately, software cannot read the status of DEFDCDC{2,3} pins.
> So, this information is passed through platform data depending on
> how the board is wired.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal(a)ti.com>
> Signed-off-by: Sekhar Nori <nsekhar(a)ti.com>

Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCHv9 2.6.35-rc4-tip 6/13] uprobes: X86 support for Uprobes
Next: [PATCHv9 2.6.35-rc4-tip 12/13] [RFC] perf: Show Potential probe points.