From: Mike Rapoport on
Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin(a)gmail.com>
>
> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>

Acked-by: Mike Rapoport <mike(a)compulab.co.il>

>
>>
>> - platform_set_drvdata(pdev, ri);
>> + platform_set_drvdata(pdev, rdev);
>>
>
> This would've been easier to review if you'd mentioned in the changelog
> that there were no users of the current platform data, just to show that
> you'd checked.


--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/