reiserfs:stree.c Fix variable set but not used.
in [Kernel]
|
Prev: [PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages.
Next: tracing, vmscan: Add trace events for kswapd wakeup, sleeping and direct reclaim
From: Justin P. Mattock on 14 Jun 2010 19:00 On 06/14/2010 02:47 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> On 06/14/2010 02:05 PM, Edward Shishkin wrote: >>> Justin P. Mattock wrote: >>>> Not sure if this is correct or not. >>>> the below patch gets rid of this warning message >>>> produced by gcc 4.6.0 >>>> >>>> fs/reiserfs/stree.c: In function 'search_by_key': >>>> fs/reiserfs/stree.c:602:6: warning: variable >>>> 'right_neighbor_of_leaf_node' set but not used >>>> >>>> Signed-off-by: Justin P. Mattock <justinmattock(a)gmail.com> >>> >>> Acked-by: Edward Shishkin <edward.shishkin(a)gmail.com> >>> >> >> o.k.!! >> what about the whitespace issue? > > Whitespaces should be removed. > I recommend quilt package for managing patches: > "quilt refresh --strip-trailing-whitespace" is your friend.. > > Thanks, > Edward. > o.k. I resent this.. fixed the whitespace(hopefully) and add your Acked to it. as for quilt I'll have to look into that.. (using a lfs system, so if the sourcecode is easy to deal with(build), then it's a good but if it becomes a nightmare maybe not!!). Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stefan Richter on 14 Jun 2010 19:10 On 14 Jun, Justin P. Mattock wrote: > On 06/14/2010 02:47 PM, Edward Shishkin wrote: >> Whitespaces should be removed. >> I recommend quilt package for managing patches: >> "quilt refresh --strip-trailing-whitespace" is your friend.. > > o.k. I resent this.. fixed the whitespace(hopefully) > and add your Acked to it. > as for quilt I'll have to look into that.. > (using a lfs system, so if the sourcecode is easy > to deal with(build), then it's a good but if it becomes > a nightmare maybe not!!). Since you appear to generate the patches with git, you can use "git diff --check [...]" for some basic whitespace checks (additions of trailing space, additions of space before tab). For more extensive checks, try "git diff [...] | scripts/checkpatch.pl -". Check this before you commit. If you committed already, "git commit --amend [-a] [...]" lets you alter the very last commit of course. -- Stefan Richter -=====-==-=- -==- -==== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Justin P. Mattock on 14 Jun 2010 20:10
On 06/14/2010 04:07 PM, Stefan Richter wrote: > On 14 Jun, Justin P. Mattock wrote: >> On 06/14/2010 02:47 PM, Edward Shishkin wrote: >>> Whitespaces should be removed. >>> I recommend quilt package for managing patches: >>> "quilt refresh --strip-trailing-whitespace" is your friend.. >> >> o.k. I resent this.. fixed the whitespace(hopefully) >> and add your Acked to it. >> as for quilt I'll have to look into that.. >> (using a lfs system, so if the sourcecode is easy >> to deal with(build), then it's a good but if it becomes >> a nightmare maybe not!!). > > Since you appear to generate the patches with git, you can use "git diff > --check [...]" for some basic whitespace checks (additions of trailing > space, additions of space before tab). For more extensive checks, try > "git diff [...] | scripts/checkpatch.pl -". Check this before you > commit. If you committed already, "git commit --amend [-a] [...]" lets > you alter the very last commit of course. Thanks for the info on this, copied it down in my book of commands... Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |