Prev: GFS2: Pull request (fixes)
Next: [PATCH] Drivers: pci: code style cleanup
From: Christoph Lameter on 16 Mar 2010 12:20
On Thu, 11 Mar 2010, Tejun Heo wrote:

> Lee Schermerhorn was trying to use percpu from slab.h and ran into a
> dependency loop. percpu.h was using slab.h for UP inline

The problem is that percpu.h includes slab.h for the UP case. slab.h does
not use percpu.h. Lee was trying to have topology.h use percpu.h which
fails because percpu.h uses gfp.h which in turn uses topology.h again.

Did something change there or does the description need an update?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Tejun Heo on 16 Mar 2010 19:00
Hello,

On 03/17/2010 01:16 AM, Christoph Lameter wrote:
> On Thu, 11 Mar 2010, Tejun Heo wrote:
>
>> Lee Schermerhorn was trying to use percpu from slab.h and ran into a
>> dependency loop. percpu.h was using slab.h for UP inline
>
> The problem is that percpu.h includes slab.h for the UP case.

Yes, that's the reason why slab.h is included in percpu.h
unconditionally.

> slab.h does not use percpu.h. Lee was trying to have topology.h use
> percpu.h which fails because percpu.h uses gfp.h which in turn uses
> topology.h again.

But apparently a lot of files depend on getting slab.h through
percpu.h and removing slab.h causes a lot of build breakages UP or
SMP.

> Did something change there or does the description need an update?

I don't find anything too wrong about the description?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Lameter on 17 Mar 2010 12:40
On Wed, 17 Mar 2010, Tejun Heo wrote:

> Hello,
>
> On 03/17/2010 01:16 AM, Christoph Lameter wrote:
> > On Thu, 11 Mar 2010, Tejun Heo wrote:
> >
> >> Lee Schermerhorn was trying to use percpu from slab.h and ran into a
> >> dependency loop. percpu.h was using slab.h for UP inline
> >
> > Did something change there or does the description need an update?
>
> I don't find anything too wrong about the description?

"Lee Schermerhorn nwas trying to use percpu from slab.h and ..."

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Lee Schermerhorn on 17 Mar 2010 13:20
On Wed, 2010-03-17 at 11:34 -0500, Christoph Lameter wrote:
> On Wed, 17 Mar 2010, Tejun Heo wrote:
>
> > Hello,
> >
> > On 03/17/2010 01:16 AM, Christoph Lameter wrote:
> > > On Thu, 11 Mar 2010, Tejun Heo wrote:
> > >
> > >> Lee Schermerhorn was trying to use percpu from slab.h and ran into a
> > >> dependency loop. percpu.h was using slab.h for UP inline
> > >
> > > Did something change there or does the description need an update?
> >
> > I don't find anything too wrong about the description?
>
> "Lee Schermerhorn nwas trying to use percpu from slab.h and ..."

Well, indirectly, I was including percpu.h in slab.h by way of
gpf.h/topology.h. Not actually what I was *trying* to do.

s/from slab.h/from topology.h/ is the update Christoph is indicating.
Right, Christoph?



>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Christoph Lameter on 17 Mar 2010 16:00
On Wed, 17 Mar 2010, Lee Schermerhorn wrote:

> s/from slab.h/from topology.h/ is the update Christoph is indicating.
> Right, Christoph?

Right.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  |  Next  |  Last
Pages: 1 2 3 4 5
Prev: GFS2: Pull request (fixes)
Next: [PATCH] Drivers: pci: code style cleanup