rfkill_unregister() should always be followed by rfkill_destroy()
in [Kernel]
|
Prev: mmc0: Timeout waiting for hardware interrupt.
Next: BUG kmalloc-64: Poison overwritten, INFO: Allocated in bdi_alloc_work+0x2b/0x100 age=175 cpu=1 pid=3514
From: Henrique de Moraes Holschuh on 14 Sep 2009 09:30 On Mon, 14 Sep 2009, Corentin Chary wrote: > drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++----------- > drivers/platform/x86/hp-wmi.c | 2 +- > drivers/platform/x86/thinkpad_acpi.c | 1 + These are also likely needed in 2.6.31, please add appropriate Cc: lines to stable(a)kernel.org while adding the Acked-By's. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Jenkins on 14 Sep 2009 11:00 Henrique de Moraes Holschuh wrote: > On Mon, 14 Sep 2009, Corentin Chary wrote: > >> drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++----------- >> drivers/platform/x86/hp-wmi.c | 2 +- >> drivers/platform/x86/thinkpad_acpi.c | 1 + >> > > These are also likely needed in 2.6.31, please add appropriate Cc: lines to > stable(a)kernel.org while adding the Acked-By's. > > Do they meet the -stable criteria? .... - It must fix a real bug that bothers people (not a, "This could be a problem..." type thing). - It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or some "oh, that's not good" issue. In short, something critical. .... (Documentation/stable_kernel_rules.txt) Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Henrique de Moraes Holschuh on 14 Sep 2009 13:10 On Mon, 14 Sep 2009, Alan Jenkins wrote: > Henrique de Moraes Holschuh wrote: > > On Mon, 14 Sep 2009, Corentin Chary wrote: > > > >> drivers/platform/x86/dell-laptop.c | 36 ++++++++++++++++++++++----------- > >> drivers/platform/x86/hp-wmi.c | 2 +- > >> drivers/platform/x86/thinkpad_acpi.c | 1 + > >> > > > > These are also likely needed in 2.6.31, please add appropriate Cc: lines to > > stable(a)kernel.org while adding the Acked-By's. > > Do they meet the -stable criteria? The ones for thinkpad_acpi and hp-wmi do (fix obvious bug, small and obviously correct, impossible to cause regressions). I don't know about the fix for dell-laptop since it is a lot larger. > - It must fix a real bug that bothers people (not a, "This could be a > problem..." type thing). Memory leaks are real bugs, especially these ones that _always_ happen and are not even on the error paths, but on the main code path... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Henrique de Moraes Holschuh on 14 Sep 2009 13:20
On Mon, 14 Sep 2009, Henrique de Moraes Holschuh wrote: > I don't know about the fix for dell-laptop since it is a lot larger. But looking at it, it seems to meet the -stable criteria as well. However, it looks like you're fixing two bugs there (set pointers to NULL, call _destroy()), so it would be better to have two (smaller) patches, maybe? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |