sched: remove AFFINE_WAKEUPS feature
in [Kernel]
|
From: Mike Galbraith on 11 Mar 2010 05:10 sched: remove AFFINE_WAKEUPS feature Disabling affine wakeups is too horrible to contemplate. Remove it. Signed-off-by: Mike Galbraith <efault(a)gmx.de> Cc: Ingo Molnar <mingo(a)elte.hu> Cc: Peter Zijlstra <a.p.zijlstra(a)chello.nl> LKML-Reference: <new-submission> --- kernel/sched_fair.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: linux-2.6/kernel/sched_fair.c =================================================================== --- linux-2.6.orig/kernel/sched_fair.c +++ linux-2.6/kernel/sched_fair.c @@ -1433,8 +1433,7 @@ static int select_task_rq_fair(struct ta int sync = wake_flags & WF_SYNC; if (sd_flag & SD_BALANCE_WAKE) { - if (sched_feat(AFFINE_WAKEUPS) && - cpumask_test_cpu(cpu, &p->cpus_allowed)) + if (cpumask_test_cpu(cpu, &p->cpus_allowed)) want_affine = 1; new_cpu = prev_cpu; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Yong Zhang on 11 Mar 2010 22:30 On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote: > Commit-ID: beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > Gitweb: http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > Author: Mike Galbraith <efault(a)gmx.de> > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100 > Committer: Ingo Molnar <mingo(a)elte.hu> > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100 > > sched: Remove AFFINE_WAKEUPS feature > > Disabling affine wakeups is too horrible to contemplate. Remove the feature flag. AFFINE_WAKEUPS is still left in sched_feature.h From: Yong Zhang <yong.zhang(a)windriver.com> Date: Fri, 12 Mar 2010 11:14:26 +0800 Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 Signed-off-by: Yong Zhang <yong.zhang(a)windriver.com> --- kernel/sched_features.h | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/kernel/sched_features.h b/kernel/sched_features.h index 83c66e8..2137ac0 100644 --- a/kernel/sched_features.h +++ b/kernel/sched_features.h @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1) SCHED_FEAT(WAKEUP_PREEMPT, 1) /* - * Based on load and program behaviour, see if it makes sense to place - * a newly woken task on the same cpu as the task that woke it -- - * improve cache locality. Typically used with SYNC wakeups as - * generated by pipes and the like, see also SYNC_WAKEUPS. - */ -SCHED_FEAT(AFFINE_WAKEUPS, 1) - -/* * Prefer to schedule the task we woke last (assuming it failed * wakeup-preemption), since its likely going to consume data we * touched, increases cache locality. -- 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mike Galbraith on 11 Mar 2010 23:40 On Fri, 2010-03-12 at 11:23 +0800, Yong Zhang wrote: > On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote: > > Commit-ID: beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Gitweb: http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Author: Mike Galbraith <efault(a)gmx.de> > > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100 > > Committer: Ingo Molnar <mingo(a)elte.hu> > > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100 > > > > sched: Remove AFFINE_WAKEUPS feature > > > > Disabling affine wakeups is too horrible to contemplate. Remove the feature flag. > > AFFINE_WAKEUPS is still left in sched_feature.h Oops, axe got dull. Thanks for checking. -Mike > From: Yong Zhang <yong.zhang(a)windriver.com> > Date: Fri, 12 Mar 2010 11:14:26 +0800 > Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature > > complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Signed-off-by: Yong Zhang <yong.zhang(a)windriver.com> > --- > kernel/sched_features.h | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/kernel/sched_features.h b/kernel/sched_features.h > index 83c66e8..2137ac0 100644 > --- a/kernel/sched_features.h > +++ b/kernel/sched_features.h > @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1) > SCHED_FEAT(WAKEUP_PREEMPT, 1) > > /* > - * Based on load and program behaviour, see if it makes sense to place > - * a newly woken task on the same cpu as the task that woke it -- > - * improve cache locality. Typically used with SYNC wakeups as > - * generated by pipes and the like, see also SYNC_WAKEUPS. > - */ > -SCHED_FEAT(AFFINE_WAKEUPS, 1) > - > -/* > * Prefer to schedule the task we woke last (assuming it failed > * wakeup-preemption), since its likely going to consume data we > * touched, increases cache locality. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: sched: remove SYNC_WAKEUPS feature Next: 2.6.34-rc1: rcu lockdep bug? |