Prev: ata1 timeouts on 2.6.34-rc1
Next: [GIT pull] timer fixes for 2.6.34
From: Julia Lawall on 10 Mar 2010 05:20
On Wed, 10 Mar 2010, Dan Carpenter wrote:

> I wrote a script to check that a patch only changes white space.
> It compiles the files before and after the patch is applied and
> verifies that they are the same.
>
> You'll need to compile smatch:
> git pull git://repo.or.cz/smatch.git
> make
> cd /path/to/kernel/src/
> /path/to/smatch_scripts/whitespace_only.sh <patch>
>
> Adding or removing parenthesis and curly braces counts as a code
> change. Changes to comments, #if 0, white space changes do not.
>
> You can fix a lot of style violations if you limit yourself to
> adding and removing tabs, spaces and new lines. Then the next
> patch could remove unneeded parenthesis. It would be easier to
> audit that way instead of everything mixed together.
>
> regards,
> dan carpenter
>
> PS. I feel really bad slagging the newbies trying to help.
> Could we fix checkpatch.pl to not complain about line lengths?

I hope not... Are newbies really put off by having to add a newline here
and there?

julia

> Also could we tell them to stay in staging where no one cares
> about git blame?
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: ata1 timeouts on 2.6.34-rc1
Next: [GIT pull] timer fixes for 2.6.34