soc/sh: Fix I2C dependency for SND_FSI_AK4642
in [Kernel]
|
Prev: ACPI: video: DMI workaround broken Acer 5710 BIOS enabling display brightness
Next: iwlagn completely unusable with some AP since 2.6.31
From: Mark Brown on 14 Jun 2010 12:20 On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > bool "FSI-AK4642 sound support" > depends on SND_SOC_SH4_FSI > select SND_SOC_AK4642 > + select I2C I'd have thought a depends was more appropriate. Arguably you want to depend on the SH I2C driver since the driver is useless without the relevant I2C controller. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Peter Hüwe on 15 Jun 2010 10:50 Am Montag 14 Juni 2010 18:10:34 schrieb Mark Brown: > On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote: > > bool "FSI-AK4642 sound support" > > depends on SND_SOC_SH4_FSI > > select SND_SOC_AK4642 > > + select I2C > > I'd have thought a depends was more appropriate. Arguably you want to > depend on the SH I2C driver since the driver is useless without the > relevant I2C controller. > Thanks for pointing this out - I had also a closer look at the codecs and the other FSI related codec (da7210.c) depends on I2C too. So maybe even move the dependency up to SND_SOC_SH4_FSI since both codecs rely on I2C? So something like this would be more appropriate? config SND_SOC_SH4_FSI tristate "SH4 FSI support" + depends on CONFIG_I2C_SH_MOBILE help This option enables FSI sound support If you think this patch sounds correct, I can create a new 'official' patch. Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Mark Brown on 15 Jun 2010 11:30
On Tue, Jun 15, 2010 at 04:49:07PM +0200, Peter Hüwe wrote: > So maybe even move the dependency up to SND_SOC_SH4_FSI > since both codecs rely on I2C? No, while the two boards in mainline currently may need I2C obviously other board designs with other control interfaces are possible so it should be on the individual boards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |