Prev: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem
Next: [PATCH] scsi: mpt2sas: Add space in printk
From: Takashi Iwai on 6 Aug 2010 04:10
At Thu, 5 Aug 2010 22:27:32 +0200 (CEST),
Julia Lawall wrote:
>
> From: Julia Lawall <julia(a)diku.dk>
>
> Indent the branch of an if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1(a)p1 S2(a)p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia(a)diku.dk>

Thanks, applied now.


Takashi

>
> ---
> sound/oss/ad1848.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c
> index 24793c5..4d2a6ae 100644
> --- a/sound/oss/ad1848.c
> +++ b/sound/oss/ad1848.c
> @@ -716,7 +716,7 @@ static int ad1848_mixer_ioctl(int dev, unsigned int cmd, void __user *arg)
>
> default:
> if (get_user(val, (int __user *)arg))
> - return -EFAULT;
> + return -EFAULT;
> val = ad1848_mixer_set(devc, cmd & 0xff, val);
> break;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem
Next: [PATCH] scsi: mpt2sas: Add space in printk