Prev: [git pull] driver bug fixes and mpc5200 defconfig updates
Next: powerpc/BSR: fix device_create() return value check
From: Grant Likely on 11 Mar 2010 16:30
On Thu, Mar 11, 2010 at 12:34 PM, Mark Brown
<broonie(a)opensource.wolfsonmicro.com> wrote:
> On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote:
>> .node is being removed
>>
>> Signed-off-by: Grant Likely <grant.likely(a)secretlab.ca>
>
> Acked-by: Mark Brown <broonie(a)opensource.wolfsonmicro.com>
>
> but please ensure that Liam and especially Timur also check this (both
> CCed).
>
> For enormous patch serieses like this it's really nice if you can ensure
> that each person is only CCed on the patches that they need to review.
> Much less stuff in the inbox.

Yeah, sorry about that (and to everyone receiving this thread, I'm
really sorry. I won't do it again). I've already been yelled at for
that. What happened is that on a previous series I was yelled at for
not sending all patches to everyone (so that the patches could be
reviewed in context). So, naturally, I made sure to include everyone
on the whole series this time.... doh.

Next time I post I'll constrain it to small chunks.

Thanks for the review.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Grant Likely on 5 Apr 2010 19:50
Hi Ben, thanks for the comment. Reply below...

On Mon, Apr 5, 2010 at 5:03 PM, Ben Dooks <ben-linux(a)fluff.org> wrote:
> On Thu, Mar 11, 2010 at 11:06:50AM -0700, Grant Likely wrote:
>> .node is being removed
[...]
>> --- a/sound/soc/fsl/mpc8610_hpcd.c
>> +++ b/sound/soc/fsl/mpc8610_hpcd.c
>> @@ -202,7 +202,7 @@ static struct snd_soc_ops mpc8610_hpcd_ops = {
>> �static int mpc8610_hpcd_probe(struct of_device *ofdev,
>> � � � const struct of_device_id *match)
>> �{
>> - � � struct device_node *np = ofdev->node;
>> + � � struct device_node *np = ofdev->dev.of_node;
>> � � � struct device_node *codec_np = NULL;
>> � � � struct device_node *guts_np = NULL;
>> � � � struct device_node *dma_np = NULL;
>
> This looks like one case where an inline function would have been a
> help.

In what regard (how would you like it to look)? The node pointer
location is very unlikely to move again, and I prefer the clarity of
direct dereferencing.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [git pull] driver bug fixes and mpc5200 defconfig updates
Next: powerpc/BSR: fix device_create() return value check