Prev: SATA_SIL on IXP425 workaround
Next: perf: don't use obsolete getpagesize
From: Marc Zyngier on 14 Jan 2010 12:40
On Thu, 14 Jan 2010 17:55:55 +0100
Roel Kluin <roel.kluin(a)gmail.com> wrote:

> These statements appear redundant.
>
> Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>
> ---
> Is there any reason to assign this to itself?
>
> diff --git a/arch/sparc/kernel/central.c b/arch/sparc/kernel/central.c
> index f3b5466..773caf4 100644
> --- a/arch/sparc/kernel/central.c
> +++ b/arch/sparc/kernel/central.c
> @@ -99,7 +99,6 @@ static int __devinit clock_board_probe(struct
> of_device *op,
> p->leds_resource.start = (unsigned long)
> (p->clock_regs + CLOCK_CTRL);
> - p->leds_resource.end = p->leds_resource.end;

I have the feeling that the right fix is to have:

p->leds_resource.end = p->leds_resource.start;

hence describing a 1 byte region.

M.
--
I'm the slime oozin' out from your TV set...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 14 Jan 2010 20:00
From: Roel Kluin <roel.kluin(a)gmail.com>
Date: Thu, 14 Jan 2010 17:55:55 +0100

> These statements appear redundant.
>
> Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>
> ---
> Is there any reason to assign this to itself?

It's a bug, let me try and figure out what this code is trying
to do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 15 Jan 2010 04:30
From: Roel Kluin <roel.kluin(a)gmail.com>
Date: Thu, 14 Jan 2010 20:53:14 +0100

> It should be a 1 byte region.
>
> Signed-off-by: Roel Kluin <roel.kluin(a)gmail.com>

Yes, that was the intention.

Applied, thanks Roel!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: SATA_SIL on IXP425 workaround
Next: perf: don't use obsolete getpagesize