Prev: msm_sdcc.c: remove references to htc_pwrsink
Next: [PATCH] sh: Build fix: define more __movmem* symbols
From: Pavel Machek on 28 Oct 2009 18:00

> > > With this patch, will it build properly?
> >
> > Its certainly way closer to building... it builds for me, with
> > something like below; platform devices really are initialized from
> > board-* files and get passed parameters.
>
> Ick. This isn't ok, we can't take patches for staging stuff in files
> outside of drivers/staging/

I know, I was trying to show that ammount of required changes is very small.

> So for now, I've deleted the drivers/staging/dream/ directory from my
> tree, which will get pushed for 2.6.33. Please clean the code up and
> get it into buildable shape and I will be glad to add the drivers back
> into the staging directory at that time.

Ok, I got something that builds; verifying it on device is hard, as
last kernel that boots there is 2.6.29...

Should I turn it into series and submit?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 Oct 2009 18:20
On Wed, Oct 28, 2009 at 10:56:12PM +0100, Pavel Machek wrote:
>
> > > > With this patch, will it build properly?
> > >
> > > Its certainly way closer to building... it builds for me, with
> > > something like below; platform devices really are initialized from
> > > board-* files and get passed parameters.
> >
> > Ick. This isn't ok, we can't take patches for staging stuff in files
> > outside of drivers/staging/
>
> I know, I was trying to show that ammount of required changes is very small.
>
> > So for now, I've deleted the drivers/staging/dream/ directory from my
> > tree, which will get pushed for 2.6.33. Please clean the code up and
> > get it into buildable shape and I will be glad to add the drivers back
> > into the staging directory at that time.
>
> Ok, I got something that builds; verifying it on device is hard, as
> last kernel that boots there is 2.6.29...
>
> Should I turn it into series and submit?

Yes please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 28 Oct 2009 18:50
On Wed 2009-10-28 15:11:55, Greg KH wrote:
> On Wed, Oct 28, 2009 at 10:56:12PM +0100, Pavel Machek wrote:
> >
> > > > > With this patch, will it build properly?
> > > >
> > > > Its certainly way closer to building... it builds for me, with
> > > > something like below; platform devices really are initialized from
> > > > board-* files and get passed parameters.
> > >
> > > Ick. This isn't ok, we can't take patches for staging stuff in files
> > > outside of drivers/staging/
> >
> > I know, I was trying to show that ammount of required changes is very small.
> >
> > > So for now, I've deleted the drivers/staging/dream/ directory from my
> > > tree, which will get pushed for 2.6.33. Please clean the code up and
> > > get it into buildable shape and I will be glad to add the drivers back
> > > into the staging directory at that time.
> >
> > Ok, I got something that builds; verifying it on device is hard, as
> > last kernel that boots there is 2.6.29...
> >
> > Should I turn it into series and submit?
>
> Yes please.

Ok, here you go. These are against your tree before your "rm -r"
patch. I hope I did not make mistake somewhere.
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2 3
Prev: msm_sdcc.c: remove references to htc_pwrsink
Next: [PATCH] sh: Build fix: define more __movmem* symbols