Prev: staging: hv: Gracefully handle SCSI resets
Next: staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely
From: Greg KH on 3 Aug 2010 13:50
On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
> From: Hank Janssen <hjanssen(a)microsoft.com>
>
> Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.

Same questions for you as patch 1/6.

Also, please wrap your changelog comments at 72 columns.

>
> Signed-off-by:Hank Janssen <hjanssen(a)microsoft.com>
> Signed-off-by:Haiyang Zhang <haiyangz(a)microsoft.com>

What's with the trailing space?

>
> ---
> drivers/staging/hv/storvsc_drv.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
> index 3b9ccb0..169d701 100644
> --- a/drivers/staging/hv/storvsc_drv.c
> +++ b/drivers/staging/hv/storvsc_drv.c
> @@ -615,6 +615,7 @@ static int storvsc_queuecommand(struct scsi_cmnd *scmnd,
> unsigned int request_size = 0;
> int i;
> struct scatterlist *sgl;
> + unsigned int sg_count = 0;
>
> DPRINT_DBG(STORVSC_DRV, "scmnd %p dir %d, use_sg %d buf %p len %d "
> "queue depth %d tagged %d", scmnd, scmnd->sc_data_direction, @@ -697,6 +698,7 @@ static int storvsc_queuecommand(struct scsi_cmnd *scmnd,
> request->DataBuffer.Length = scsi_bufflen(scmnd);
> if (scsi_sg_count(scmnd)) {
> sgl = (struct scatterlist *)scsi_sglist(scmnd);
> + sg_count = scsi_sg_count(scmnd);
>
> /* check if we need to bounce the sgl */
> if (do_bounce_buffer(sgl, scsi_sg_count(scmnd)) != -1) { @@ -731,15 +733,16 @@ static int storvsc_queuecommand(struct scsi_cmnd *scmnd,
> scsi_sg_count(scmnd));
>
> sgl = cmd_request->bounce_sgl;
> + sg_count = cmd_request->bounce_sgl_count;
> }
>
> request->DataBuffer.Offset = sgl[0].offset;
>
> - for (i = 0; i < scsi_sg_count(scmnd); i++) {
> + for (i = 0; i < sg_count; i++) {
> DPRINT_DBG(STORVSC_DRV, "sgl[%d] len %d offset %d\n",
> i, sgl[i].length, sgl[i].offset);
> - request->DataBuffer.PfnArray[i] =
> - page_to_pfn(sg_page((&sgl[i])));
> + request->DataBuffer.PfnArray[i] =

Trailing space here?

You didn't run 'checkpatch.pl' now did you :)

You should set your editor to show up trailing spaces in bright red to
keep this from happening. I can tell you how to do this in vim, all
other editors, you are on your own.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Hank Janssen on 4 Aug 2010 00:40
And then Greg spoke:
>> On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
>> From: Hank Janssen <hjanssen(a)microsoft.com>
> >
> >Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.
>
>Same questions for you as patch 1/6.
>
>Also, please wrap your changelog comments at 72 columns.

Under heavy loads with many clients we this problem appears, it causes a kernel
Panic.

Yes, this should be backported to all stable kernel releases that have the
Hyper-V drivers In them.

>> Signed-off-by:Hank Janssen <hjanssen(a)microsoft.com>
>> Signed-off-by:Haiyang Zhang <haiyangz(a)microsoft.com>
>
>What's with the trailing space?

Same problem as wrapping my comments at 72 chars, I just upgraded to the latest
Evil outlook 2010, and my settings in office 2007 did not transfer so I have to
Set up all the stuff that fixes these problems :(

Do you want me to re-submit with correct wrapping?

Thanks,

Hank.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 4 Aug 2010 13:20
On Wed, Aug 04, 2010 at 04:32:17AM +0000, Hank Janssen wrote:
> And then Greg spoke:
> >> On Tue, Aug 03, 2010 at 05:31:53PM +0000, Hank Janssen wrote:
> >> From: Hank Janssen <hjanssen(a)microsoft.com>
> > >
> > >Fixed lockup problem with bounce_buffer scatter list which caused crashes in heavy loads.
> >
> >Same questions for you as patch 1/6.
> >
> >Also, please wrap your changelog comments at 72 columns.
>
> Under heavy loads with many clients we this problem appears, it causes a kernel
> Panic.

Great, please provide this info.

> Yes, this should be backported to all stable kernel releases that have the
> Hyper-V drivers In them.

Again, add a cc: stable <stable(a)kernel.org> to the patch please.

> >> Signed-off-by:Hank Janssen <hjanssen(a)microsoft.com>
> >> Signed-off-by:Haiyang Zhang <haiyangz(a)microsoft.com>
> >
> >What's with the trailing space?
>
> Same problem as wrapping my comments at 72 chars, I just upgraded to the latest
> Evil outlook 2010, and my settings in office 2007 did not transfer so I have to
> Set up all the stuff that fixes these problems :(
>
> Do you want me to re-submit with correct wrapping?

Yes. But you also have trailing spaces in some of these patches as
well, which need to be addressed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: staging: hv: Gracefully handle SCSI resets
Next: staging: hv: Removed TODO for VMBUS, it mirrors HYPER-V behavior to closely