staging/line6: needs to select SND_PCM
in [Kernel]
|
Prev: BUG: 'Unknown symbol in module' happens after reloading ehci-hcd module
Next: [PATCH 1/2] [PATCH] x86: Look for TSC Deadline Timer
From: Takashi Iwai on 28 Jul 2010 10:10 At Tue, 27 Jul 2010 12:21:19 -0700, Randy Dunlap wrote: > > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > line6 uses snd_pcm*() functions, so it should select SND_PCM. > > ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined! > ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> > Cc: Markus Grabner <grabner(a)icg.tugraz.at> > --- > drivers/staging/line6/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Third patch to staging/line6/Kconfig. :( > Developers should know what kernel services their code needs > and how to configure for those needs. I think this should be applied rather to 2.6.35 tree. thanks, Takashi > --- linux-next-20100727.orig/drivers/staging/line6/Kconfig > +++ linux-next-20100727/drivers/staging/line6/Kconfig > @@ -2,6 +2,7 @@ config LINE6_USB > tristate "Line6 USB support" > depends on USB && SND > select SND_RAWMIDI > + select SND_PCM > help > This is a driver for the guitar amp, cab, and effects modeller > PODxt Pro by Line6 (and similar devices), supporting the > -- > To unsubscribe from this list: send the line "unsubscribe linux-next" in > the body of a message to majordomo(a)vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on 28 Jul 2010 11:30
On Wed, Jul 28, 2010 at 03:59:50PM +0200, Takashi Iwai wrote: > At Tue, 27 Jul 2010 12:21:19 -0700, > Randy Dunlap wrote: > > > > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > > > line6 uses snd_pcm*() functions, so it should select SND_PCM. > > > > ERROR: "snd_pcm_period_elapsed" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_set_ops" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_lib_free_pages" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_lib_ioctl" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_lib_malloc_pages" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_hw_constraint_ratdens" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_format_physical_width" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_lib_preallocate_pages_for_all" [drivers/staging/line6/line6usb.ko] undefined! > > ERROR: "snd_pcm_new" [drivers/staging/line6/line6usb.ko] undefined! > > > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> > > Cc: Markus Grabner <grabner(a)icg.tugraz.at> > > --- > > drivers/staging/line6/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > Third patch to staging/line6/Kconfig. :( > > Developers should know what kernel services their code needs > > and how to configure for those needs. > > I think this should be applied rather to 2.6.35 tree. I'll queue this up for stable to get it into the .35 tree eventually :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |