Prev: [PATCH] usb: gadget: g_mass_storage: static data instead of dynamic allocation
Next: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat
From: Joe Perches on 13 May 2010 14:10
On Thu, 2010-05-13 at 23:08 +0530, Prashant P. Shah wrote:
> drivers/staging/rtl8187se/r8180_core.c | 1622 ++++++++++++++++----------------
> 1 files changed, 806 insertions(+), 816 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 84a745b..37be5ae 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -66,23 +66,23 @@ static int hwseqnum = 0;
> static int hwwep = 0;
> static int channels = 0x3fff;
>
> -#define eqMacAddr(a,b) ( ((a)[0]==(b)[0] && (a)[1]==(b)[1] && (a)[2]==(b)[2] && (a)[3]==(b)[3] && (a)[4]==(b)[4] && (a)[5]==(b)[5]) ? 1:0 )
> -#define cpMacAddr(des,src) ((des)[0]=(src)[0],(des)[1]=(src)[1],(des)[2]=(src)[2],(des)[3]=(src)[3],(des)[4]=(src)[4],(des)[5]=(src)[5])
> +#define eqMacAddr(a, b) (((a)[0] == (b)[0] && (a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && (a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
> +#define cpMacAddr(des, src) ((des)[0] = (src)[0], (des)[1] = (src)[1], (des)[2] = (src)[2], (des)[3] = (src)[3], (des)[4] = (src)[4], (des)[5] = (src)[5])

Just use compare_ether_addr and memcpy directly


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] usb: gadget: g_mass_storage: static data instead of dynamic allocation
Next: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat