Prev: [PATCH 1/2] drivers/serial/icom.c: Eliminate use after free
Next: [PATCH 2/2] arch/arm/common: Eliminate use after free
From: David Daney on 30 Jul 2010 11:20
On 07/30/2010 04:07 AM, Kulikov Vasiliy wrote:
> request_irq() may fail, if so propagate error code.
>
> Signed-off-by: Kulikov Vasiliy<segooon(a)gmail.com>

You can add:

Acked-by: David Daney <ddaney(a)caviumnetworks.com>


> ---
> drivers/staging/octeon/ethernet-spi.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet-spi.c b/drivers/staging/octeon/ethernet-spi.c
> index b58b897..9708254 100644
> --- a/drivers/staging/octeon/ethernet-spi.c
> +++ b/drivers/staging/octeon/ethernet-spi.c
> @@ -294,6 +294,8 @@ int cvm_oct_spi_init(struct net_device *dev)
> if (number_spi_ports == 0) {
> r = request_irq(OCTEON_IRQ_RML, cvm_oct_spi_rml_interrupt,
> IRQF_SHARED, "SPI",&number_spi_ports);
> + if (r)
> + return r;
> }
> number_spi_ports++;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 1/2] drivers/serial/icom.c: Eliminate use after free
Next: [PATCH 2/2] arch/arm/common: Eliminate use after free