staging/rar_register: depends on PCI
in [Kernel]
|
Prev: patch usb-gadget-webcam-depends-on-video_dev.patch added to gregkh-2.6 tree
Next: kbuild: fixing the select problem
From: Alan Cox on 5 May 2010 20:00 On Wed, 5 May 2010 15:45:22 -0700 Randy Dunlap <randy.dunlap(a)oracle.com> wrote: > From: Randy Dunlap <randy.dunlap(a)oracle.com> > > rar_register driver uses PCI interfaces and PCI devices, so it > should depend on PCI. > > Also format the Kconfig help text as normally done. > > drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get' > drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast > > Note: The memrar driver selects this driver's Kconfig symbol, even when > PCI is not enabled. That select could be changed to > select RAR_REGISTER if PCI > but that would still result in build errors when PCI is not enabled, namely: > drivers/built-in.o: In function `memrar_fini_rar_resources': > memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar' > drivers/built-in.o: In function `memrar_registration_callback': > memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address' > drivers/built-in.o: In function `memrar_init': > memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar' > memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar' > > Does anyone have suggestions for this? Yes - memrar should depend upon the RAR_REGISTER > > Signed-off-by: Randy Dunlap <randy.dunlap(a)oracle.com> Acked-by: Alan Cox <alan(a)linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on 5 May 2010 22:40
On 05/05/10 16:55, Alan Cox wrote: > On Wed, 5 May 2010 15:45:22 -0700 > Randy Dunlap <randy.dunlap(a)oracle.com> wrote: > >> From: Randy Dunlap <randy.dunlap(a)oracle.com> >> >> rar_register driver uses PCI interfaces and PCI devices, so it >> should depend on PCI. >> >> Also format the Kconfig help text as normally done. >> >> drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get' >> drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast >> >> Note: The memrar driver selects this driver's Kconfig symbol, even when >> PCI is not enabled. That select could be changed to >> select RAR_REGISTER if PCI >> but that would still result in build errors when PCI is not enabled, namely: >> drivers/built-in.o: In function `memrar_fini_rar_resources': >> memrar_handler.c:(.text+0x2391b7): undefined reference to `unregister_rar' >> drivers/built-in.o: In function `memrar_registration_callback': >> memrar_handler.c:(.text+0x23925a): undefined reference to `rar_get_address' >> drivers/built-in.o: In function `memrar_init': >> memrar_handler.c:(.init.text+0x12c7b): undefined reference to `register_rar' >> memrar_handler.c:(.init.text+0x12c97): undefined reference to `register_rar' >> >> Does anyone have suggestions for this? > > Yes - memrar should depend upon the RAR_REGISTER memrar currently selects RAR_REGISTER, but I'll be happy to change that to depends on... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |