From: Greg KH on
On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote:
> Remove all rcu head inits. We don't care about the RCU head state before passing
> it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> keep track of objects on stack.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
> Signed-off-by: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
> Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
> ---
> drivers/staging/batman-adv/hard-interface.c | 1 -

Is this safe to apply to my tree now? Or do you want to take it through
your tree as it depends on other stuff?

If your tree, no objection from me, feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh(a)suse.de>

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Paul E. McKenney on
On Tue, May 11, 2010 at 04:45:23PM -0700, Greg KH wrote:
> On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote:
> > Remove all rcu head inits. We don't care about the RCU head state before passing
> > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> > keep track of objects on stack.
> >
> > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
> > Signed-off-by: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
> > Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
> > ---
> > drivers/staging/batman-adv/hard-interface.c | 1 -
>
> Is this safe to apply to my tree now? Or do you want to take it through
> your tree as it depends on other stuff?

Because the rcu_head in this case is not in an auto (on-stack) variable,
this commit is safe to apply to your tree now.

Let me know when you have applied it, and I will happily remove it
from mine. ;-)

Thanx, Paul

> If your tree, no objection from me, feel free to add:
> Acked-by: Greg Kroah-Hartman <gregkh(a)suse.de>
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Greg KH on
On Tue, May 11, 2010 at 05:08:21PM -0700, Paul E. McKenney wrote:
> On Tue, May 11, 2010 at 04:45:23PM -0700, Greg KH wrote:
> > On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote:
> > > Remove all rcu head inits. We don't care about the RCU head state before passing
> > > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> > > keep track of objects on stack.
> > >
> > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
> > > Signed-off-by: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
> > > Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
> > > ---
> > > drivers/staging/batman-adv/hard-interface.c | 1 -
> >
> > Is this safe to apply to my tree now? Or do you want to take it through
> > your tree as it depends on other stuff?
>
> Because the rcu_head in this case is not in an auto (on-stack) variable,
> this commit is safe to apply to your tree now.
>
> Let me know when you have applied it, and I will happily remove it
> from mine. ;-)

Now queued up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Paul E. McKenney on
On Fri, May 14, 2010 at 01:16:40PM -0700, Greg KH wrote:
> On Tue, May 11, 2010 at 05:08:21PM -0700, Paul E. McKenney wrote:
> > On Tue, May 11, 2010 at 04:45:23PM -0700, Greg KH wrote:
> > > On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote:
> > > > Remove all rcu head inits. We don't care about the RCU head state before passing
> > > > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can
> > > > keep track of objects on stack.
> > > >
> > > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com>
> > > > Signed-off-by: Paul E. McKenney <paulmck(a)linux.vnet.ibm.com>
> > > > Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
> > > > ---
> > > > drivers/staging/batman-adv/hard-interface.c | 1 -
> > >
> > > Is this safe to apply to my tree now? Or do you want to take it through
> > > your tree as it depends on other stuff?
> >
> > Because the rcu_head in this case is not in an auto (on-stack) variable,
> > this commit is safe to apply to your tree now.
> >
> > Let me know when you have applied it, and I will happily remove it
> > from mine. ;-)
>
> Now queued up.

And happily removed from mine.

Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/