staging: winbond: sme_api.h Coding style fixes.
in [Kernel]
|
Prev: staging: winbond: mds_f.h whitespace and CamelCase corrections.
Next: atmel_serial: Atmel RS485 support
From: Pavel Machek on 21 Mar 2010 16:20 On Sun 2010-03-21 17:55:03, Lars Lindley wrote: > I fixed the things reported by checkpatch.pl except > one long line and a __inline. > I also removed commented away code and versioning comments. > > Signed-off-by: Lars Lindley <lindley(a)coyote.org> ACK. > @@ -18,42 +12,42 @@ > #include "localpara.h" > > /****************** CONSTANT AND MACRO SECTION ******************************/ > -#define _INLINE __inline > +#define _INLINE __inline doing s/_INLINE/__inline/ on whole sources would be nice.... -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pavel Machek on 21 Mar 2010 16:30 > >> @@ -18,42 +12,42 @@ > >> �#include "localpara.h" > >> > >> �/****************** CONSTANT AND MACRO SECTION ******************************/ > >> -#define _INLINE � � �__inline > >> +#define _INLINE � � � � � � � � � � � � � � �__inline > > > > doing s/_INLINE/__inline/ on whole sources would be nice.... > > We probably can just get rid of most of the inlines in the driver > code, I think. Yes. I do not think this driver is performance-critical, and GCC can probably outsmart us. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Pekka Enberg on 21 Mar 2010 16:40
On Sun, Mar 21, 2010 at 10:12 PM, Pavel Machek <pavel(a)ucw.cz> wrote: > On Sun 2010-03-21 17:55:03, Lars Lindley wrote: >> I fixed the things reported by checkpatch.pl except >> one long line and a __inline. >> I also removed commented away code and versioning comments. >> >> Signed-off-by: Lars Lindley <lindley(a)coyote.org> > > ACK. Acked-by: Pekka Enberg <penberg(a)cs.helsinki.fi> >> @@ -18,42 +12,42 @@ >> �#include "localpara.h" >> >> �/****************** CONSTANT AND MACRO SECTION ******************************/ >> -#define _INLINE � � �__inline >> +#define _INLINE � � � � � � � � � � � � � � �__inline > > doing s/_INLINE/__inline/ on whole sources would be nice.... We probably can just get rid of most of the inlines in the driver code, I think. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |