tcp: bugs and cleanup for 2.6.34-rc1
in [Kernel]
|
Prev: [PATCHv2] fs: fat: use pack_hex_byte() instead of custom one
Next: arch/powerpc/platforms/pseries: Use kasprintf
From: Eric Dumazet on 11 Mar 2010 10:10 Le jeudi 11 mars 2010 à 06:35 -0500, William Allen Simpson a écrit : > I'd have thought that there would be greater interest about patching > crashing bugs, signed versus unsigned (underflow) bugs, TCP DoS bugs, > TCP data corruption, and TCP performance problems.... > > There's been ample warning. Zero-day security issues will be reported > to the usual announcement lists. In particular, these 0day exploits > affect systems as far back as the 2005 changeover to git. > > Combination of patches reported in October, November, December, January, > and February, for 2.6.32, 2.6.33, and now 2.6.34. > > This code has had previous review and several months of limited testing. > > Some portions were removed during the various TCPCT part 1 patch splits, > then were cut off by the sudden unexpected end of that merge window. > [03 Dec 2009] I've restarted the sub-numbering (again). > > Of particular interest are the TCPCT header extensions that already > appear in the next phase of testing with other platforms. These patches > allow correct reception without data corruption. > > The remainder of the original TCPCT part 2 will be merged with part 3. > > [Updated to 2010 Mar 08 2.6.34-rc1.] > -- Mr William Allen Simpson It would be nice if you could update your knowledge of how linux development works these days. Please spend few hours for that, it will save us lot of time. Our time is valuable as much as yours, I doubt we'll change our habits to fit your wills. You throw too many changes at once to let them being reviewed, understood, and accepted. For your information, we had to correct a fatal bug introduced by your last commits, and as far as I know, you didnt help that much. http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=28b2774a0d5852236dab77a4147b8b88548110f1 <at this moment of time> We are post linux-2.6.34-rc1, so only bug fixes are wanted by Linus and David, to be integrated in 2.6.34 (and previous versions if needed) We are _not_ interested by new stuff at *this* moment, especially if it takes lot of time to review. </at this moment of time> New network stuff (for 2.6.35 or 2.6.36) should be validated once net-next-2.6 re-opens (in about one week I suppose, David will send a mail to netdev to let us/you know the exact moment). So please split your patches again and submit only bug fixes to netdev. Once accepted by community and maintainer, David will push them upstream. Then, in about 10 days, please submit new stuff that hopefully find their way if you accept our reviews and comments. Last time I made some comments on your patches, you just ignored them or loaned, because obviously who is Eric Dumazet to tell William Allen Simpson how things should be done ? Silly me ! I remember this fairly well, this is why I ignored your last submissions (and privately explained to you why I did this). Speaking for myself, but as your previous mails were ignored, I felt it was time to clarify the points. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: William Allen Simpson on 11 Mar 2010 12:40 On 3/11/10 10:01 AM, Eric Dumazet wrote: > It would be nice if you could update your knowledge of how linux > development works these days. > Perhaps you could supply pointers to the relevant documentation? > You throw too many changes at once to let them being reviewed, > understood, and accepted. > These were originally submitted in groups of 1, 2, and 3 patches for review. For example, as TCPCT parts 1h and 1i (and had been part of earlier patch series, too), as of 2009-12-03: http://patchwork.ozlabs.org/patch/40284/ Resubmitted again in even finer grained patches, as of 2009-12-31 and again 2010-01-06: http://lkml.org/lkml/2010/1/6/299 Since February, I've grouped them all together, as they've been reviewed, and re-reviewed -- yet only deprecated by the netdev maintainer. > For your information, we had to correct a fatal bug introduced by your > last commits, and as far as I know, you didnt help that much. > > http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=28b2774a0d5852236dab77a4147b8b88548110f1 > Splendid! Thank you for the heads up! Unfortunately, that 3 day old email wasn't CC'd to me. I'm glad to hear that Mika is testing. And thank you for testing the patch. (You did test, didn't you?) Testing is always good! That code always worked for me, and presumably for Adam (who wrote it). We've always used small amounts of data -- only 64 bytes, as originally specified. The latest API document allows up to 1220. Folks just keep wanting more! (The latest API also drops the subscript, so that patch would have been changed eventually....) This code (PATCH v3 5/7) handles the data on the receiving side of the same transaction, a patch that was first submitted over 18 months ago! > <at this moment of time> > > We are post linux-2.6.34-rc1, so only bug fixes are wanted by Linus and > David, to be integrated in 2.6.34 (and previous versions if needed) > > We are _not_ interested by new stuff at *this* moment, especially if it > takes lot of time to review. > > </at this moment of time> > Good. Because this isn't new stuff. It's bug fixes and related cleanup. Generally, the cleanup was needed to find and test the bugs and patches. They're already "split up" from the main set of patches, as Ilpo asked over 4 months ago. I've not been making *any* new submissions around here, until *existing* submissions have been applied. > Last time I made some comments on your patches, you just ignored them or > loaned, because obviously who is Eric Dumazet to tell William Allen > Simpson how things should be done ? Silly me ! > Last time you made any comments at all, it was trivial argument about parenthesis and casts. I asked directly for more *substantive* review: http://lkml.org/lkml/2010/1/13/162 Thankfully, we've had substantive review from Andi over a period of months, on parts 3 and 4 of the current patch series.... And a short attaboy of part 2 a couple of weeks ago. > Speaking for myself, but as your previous mails were ignored, I felt it > was time to clarify the points. > Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Joe Perches on 11 Mar 2010 13:20 On Thu, 2010-03-11 at 12:38 -0500, William Allen Simpson wrote: > > http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=28b2774a0d5852236dab77a4147b8b88548110f1 In that patch, it might be better to use u16 s_data_desired = 0; not int s_data_desired = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: William Allen Simpson on 12 Mar 2010 08:30 On 3/11/10 1:14 PM, Joe Perches wrote: > On Thu, 2010-03-11 at 12:38 -0500, William Allen Simpson wrote: >>> http://git2.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=28b2774a0d5852236dab77a4147b8b88548110f1 > > In that patch, it might be better to use > u16 s_data_desired = 0; > not > int s_data_desired = 0; > Actually, Eric wrote that part of the message, and that patch. I expect that ship has sailed, but you could submit a patch.... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Américo Wang on 13 Mar 2010 00:30
On Thu, Mar 11, 2010 at 12:38:17PM -0500, William Allen Simpson wrote: > On 3/11/10 10:01 AM, Eric Dumazet wrote: >> It would be nice if you could update your knowledge of how linux >> development works these days. >> > Perhaps you could supply pointers to the relevant documentation? > > Documentation/development-process/* are still nice documents. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |